Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove `/bin/ls` assumption from check-toc test. #2677

Merged
merged 1 commit into from Aug 18, 2019

Conversation

@davidtwco
Copy link
Contributor

commented Aug 3, 2019

On some systems, notably NixOS, there is no /bin/ls and thus this test can fail unnecessarily on those systems. This PR uses /usr/bin/env ls which resolves the issue.

Remove `/bin/ls` assumption.
On some systems, notably NixOS, there is no `/bin/ls` and thus this test
can fail unnecessarily on those systems. This commit uses
`/usr/bin/env ls` which resolves the issue.
@w0rp
w0rp approved these changes Aug 18, 2019

@w0rp w0rp merged commit 91636cf into dense-analysis:master Aug 18, 2019

1 check passed

Travis CI - Pull Request Build Passed
Details
@w0rp

This comment has been minimized.

Copy link
Member

commented Aug 18, 2019

Cheers! 🍻

@davidtwco davidtwco deleted the davidtwco:check-toc-test-failure branch Aug 22, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.