Skip to content

Conversation

@maxice8
Copy link
Contributor

@maxice8 maxice8 commented Nov 1, 2020

  • Add handler for the output of atools
  • Add linters for apkbuild-lint and secfixes-check from atools
  • document support for apkbuild-lint and secfixes-check for apkbuild
  • Make apkbuild_lint and secfixes_check default for apkbuild filetype
  • Document new default linters for apkbuild
  • Test default linters for apkbuild
  • Add tests for atools handler, basic and dealing with Error and Warning
  • Add document for apkbuild filetype

@maxice8
Copy link
Contributor Author

maxice8 commented Nov 7, 2020

.

@maxice8
Copy link
Contributor Author

maxice8 commented Nov 10, 2020

Rebased

@stale
Copy link

stale bot commented Dec 8, 2020

This pull request has been automatically marked as stale because it has not been updated recently. Make sure to write tests and document your changes. See :help ale-dev for information on writing tests.
If your pull request is good to merge, bother w0rp or another maintainer again, and get them to merge it.

@stale stale bot added stale PRs/Issues no longer valid and removed stale PRs/Issues no longer valid labels Dec 8, 2020
@maxice8
Copy link
Contributor Author

maxice8 commented Dec 8, 2020

.

@maxice8
Copy link
Contributor Author

maxice8 commented Dec 8, 2020

..

@maxice8
Copy link
Contributor Author

maxice8 commented Dec 8, 2020

...

@maxice8
Copy link
Contributor Author

maxice8 commented Dec 8, 2020

....

@maxice8
Copy link
Contributor Author

maxice8 commented Dec 8, 2020

:shipit:

@RyanSquared
Copy link
Member

Please don't spam comments.

@RyanSquared
Copy link
Member

LGTM 👍

I am not able to actively help contributing ATM but it looks fine.

@stale
Copy link

stale bot commented Jan 5, 2021

This pull request has been automatically marked as stale because it has not been updated recently. Make sure to write tests and document your changes. See :help ale-dev for information on writing tests.
If your pull request is good to merge, bother w0rp or another maintainer again, and get them to merge it.

@stale stale bot added the stale PRs/Issues no longer valid label Jan 5, 2021
@maxice8
Copy link
Contributor Author

maxice8 commented Jan 5, 2021

no

@stale stale bot removed the stale PRs/Issues no longer valid label Jan 5, 2021
@hsanson
Copy link
Contributor

hsanson commented Jan 22, 2021

ALE migrated from Travis to Github Actions (see #3548) so it is necessary to rebase this PR from latest master branch to trigger the required checks.

# Add dense-analysis as remote upstream on your local fork. Not 
# needed if already added.
git remote add upstream https://github.com/dense-analysis/ale.git

# Sync your local master with upstream master
git checkout master
git fetch upstream master
git merge upstream/master

# Rebase the PR branch with master
git checkout my-branch-name
git rebase master   # Fix any conflicts you may have

# Force push the updated PR branch to origin to trigger the checks
git push -f origin my-branch-name

Copy link
Contributor

@hsanson hsanson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@hsanson hsanson merged commit a6dfc61 into dense-analysis:master Jan 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants