-
-
Notifications
You must be signed in to change notification settings - Fork 955
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Elm Section #528
Add Elm Section #528
Conversation
This is one of the comprehensive feature PR I've seen in this repo, awesome @ajlende 👏 What do you think about this,
From #253 (comment) |
No, I've been handling needing multiple versions by having differently named binaries. Similar to how Python has
Historically, a new version of Elm has been released every 6-9 months. However, Elm still hasn't hit the first stable version, so each has had pretty significant backwards-incompatible changes.
I originally had this built into #527 ( @salmanulfarzy Thanks for scrutinizing new features to this. To me, that means I'll be able to keep using spaceship-prompt knowing that it's not going to get bloated with useless features. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some minor suggestion about code formatting and tests
Just noted the following from #527 (comment)
This does look like good use case to display version information.
I think they are better as separate sections. @denysdovhan prefers each section as atomic as possible -- #340 (comment) |
Signed-off-by: Salmanul Farzy <salmanulfarzy@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Merging this as previously approved
Thank you for contributing @ajlende 🎉 |
Thanks for you pull-request!
Please, make sure you've read
CONTRIBUTING.md
before submitting this PR.Description
This adds support for Elm since #253 hasn't been touched in almost a year. I'm making a companion section for getting information for individual projects in #527.
I added some tests as well, but this is my first time doing tests for shell scripts, so let me know if I've done those correctly.
Screenshot
Please, attach a screenshot, if possible.