New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Selective prepending for ruby version #58

Merged
merged 1 commit into from Feb 15, 2017

Conversation

Projects
None yet
2 participants
@gizotti
Copy link
Contributor

gizotti commented Feb 10, 2017

This PR adds a selective prepending of a v char to ruby versions.

Prepending a v is great when ruby_version is in the number only format like 2.4.0, however rvm doesn't display MRI in that form but as ruby-2.4.0, and the version ends up displayed as vruby-2.4.0.

The same happen to other ruby implementations like jruby.

This is how it looks before patching:

image

image

This is after:

image

@denysdovhan denysdovhan self-requested a review Feb 12, 2017

@denysdovhan denysdovhan merged commit 55d8b73 into denysdovhan:master Feb 15, 2017

@gizotti gizotti deleted the gizotti:ruby-version-display branch Feb 15, 2017

@gizotti

This comment has been minimized.

Copy link
Contributor Author

gizotti commented Feb 15, 2017

💚 Thanks @denysdovhan

@denysdovhan

This comment has been minimized.

Copy link
Owner

denysdovhan commented Feb 15, 2017

Thanks for contributing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment