Attempting to update rubocop #822
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mdbenjam
commented
Jan 9, 2018
| @@ -9,7 +9,7 @@ def self.run(command) | |||
| puts(line) | |||
| end | |||
|
|
|||
| success = thread.value == 0 | |||
| success = thread.value.zero? | |||
There was a problem hiding this comment.
Changed by hand. Tested by running rake commands which all rely on it.
mdbenjam
commented
Jan 9, 2018
| @@ -1,13 +1,14 @@ | |||
| class DocumentCreator | |||
| include ActiveModel::Model | |||
|
|
|||
| attr_accessor :manifest_source, :external_documents | |||
| attr_accessor :manifest_source | |||
| attr_writer :external_documents | |||
There was a problem hiding this comment.
Changed by hand. Should work if tests pass since external_documents is written to in several jobs.
mdbenjam
commented
Jan 9, 2018
| @@ -2,14 +2,15 @@ class CssAuthenticationSession | |||
| include ActiveModel::Model | |||
| include ActiveModel::Serializers::JSON | |||
|
|
|||
| attr_accessor :id, :css_id, :email, :name, :roles, :station_id | |||
| attr_accessor :id, :name, :roles, :station_id | |||
mdbenjam
commented
Jan 9, 2018
| @@ -22,7 +22,7 @@ def document_download_failed(error_kind) | |||
| status = 500 | |||
| message = "Caseflow eFolder failed to fetch document contents." | |||
|
|
|||
| if error_kind == :vva_error || error_kind == :vbms_error | |||
| if [:vva_error, :vbms_error].include?(error_kind) | |||
There was a problem hiding this comment.
Changed by hand. Tested in documents_spec.rb test: returns 502 if there is a VBMS error
mdbenjam
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our version of Rubocop had a vulnerability. Upgrading causes new rules to be added. I mimicked most of what was done in: https://github.com/department-of-veterans-affairs/caseflow/pull/4312/files. Where only one thing was flagged by a rule, I fixed that one instance, and called it out in the PR.
Test Plan