[PART 1] Create a "priority only" distribution

app/controllers/distributions_controller.rb

@@ -38,7 +38,7 @@ def enqueue_distribution_job(distribution)
 
   def render_errors(error)
     errors = error.record.errors.details.values.flatten.map { |error_details| error_details[:error] }
-    return render_single(pending_distribution) if errors.include? :pending_distribution
+    return render_single(pending_distributions.first) if errors.include? :pending_distribution
 
     render_403_error(errors)
   end
@@ -101,7 +101,7 @@ def json_error(error)
     end
   end
 
-  def pending_distribution
+  def pending_distributions
     Distribution.pending_for_judge(judge)
   end
 

app/models/concerns/ama_case_distribution.rb

@@ -17,6 +17,22 @@ def docket_coordinator
     @docket_coordinator ||= DocketCoordinator.new
   end
 
+  def priority_push_distribution(limit = nil)
+    @appeals = []
+    @rem = 0
+
+    if limit.nil?
+      # Distribute priority appeals that are tied to judges (not genpop) with no limit.
+      distribute_appeals(:legacy, nil, priority: true, genpop: "not_genpop")
+      distribute_appeals(:hearing, nil, priority: true, genpop: "not_genpop")
+    else
+      # Distribute <limit> number of cases, regardless of docket type, oldest first.
+      oldest_priority_appeals_by_docket(limit).each do |docket, number_of_cases|
+        distribute_appeals(docket, number_of_cases, priority: true)
+      end
+    end
+  end
+
   def ama_distribution
     @appeals = []
     @rem = batch_size
@@ -59,7 +75,7 @@ def ama_distribution
 
   def ama_statistics
     {
-      batch_size: batch_size,
+      batch_size: priority_push? ? @appeals.count : batch_size,
       total_batch_size: total_batch_size,
       priority_count: priority_count,
       direct_review_due_count: direct_review_due_count,
@@ -75,7 +91,7 @@ def ama_statistics
   end
 
   def distribute_appeals(docket, num, priority: false, genpop: "any", range: nil, bust_backlog: false)
-    return [] unless num > 0
+    return [] unless num.nil? || num > 0
 
     if range.nil? && !bust_backlog
       appeals = dockets[docket].distribute_appeals(self, priority: priority, genpop: genpop, limit: num)

app/models/distribution.rb

@@ -9,8 +9,8 @@ class Distribution < CaseflowRecord
 
   validates :judge, presence: true
   validate :validate_user_is_judge, on: :create
-  validate :validate_number_of_unassigned_cases, on: :create
-  validate :validate_days_waiting_of_unassigned_cases, on: :create
+  validate :validate_number_of_unassigned_cases, on: :create, unless: :priority_push?
+  validate :validate_days_waiting_of_unassigned_cases, on: :create, unless: :priority_push?
   validate :validate_judge_has_no_pending_distributions, on: :create
 
   enum status: { pending: "pending", started: "started", error: "error", completed: "completed" }
@@ -20,13 +20,15 @@ class Distribution < CaseflowRecord
   CASES_PER_ATTORNEY = 3
   ALTERNATIVE_BATCH_SIZE = 15
 
+  scope :priority_push, -> { where(priority_push: true) }
+
   class << self
     def pending_for_judge(judge)
-      find_by(status: %w[pending started], judge: judge)
+      where(status: %w[pending started], judge: judge)
     end
   end
 
-  def distribute!
+  def distribute!(limit = nil)
     return unless %w[pending error].include? status
 
     if status == "error"
@@ -41,7 +43,7 @@ def distribute!
     multi_transaction do
       ActiveRecord::Base.connection.execute "SET LOCAL statement_timeout = #{transaction_time_out}"
 
-      ama_distribution
+      priority_push? ? priority_push_distribution(limit) : ama_distribution
 
       update!(status: "completed", completed_at: Time.zone.now, statistics: ama_statistics)
     end
@@ -74,7 +76,9 @@ def validate_days_waiting_of_unassigned_cases
   end
 
   def validate_judge_has_no_pending_distributions
-    errors.add(:judge, :pending_distribution) if self.class.pending_for_judge(judge)
+    if self.class.pending_for_judge(judge).where(priority_push: priority_push).exists?
+      errors.add(:judge, :pending_distribution)
+    end
   end
 
   def judge_tasks

app/models/dockets/hearing_request_docket.rb

@@ -20,6 +20,14 @@ def distribute_appeals(distribution, priority: false, genpop: "any", limit: 1)
       base_relation: base_relation, genpop: genpop, judge: distribution.judge
     ).call
 
+    # genpop 'any' returns 2 arrays of the limited base relation. This means if we only request 2 cases, appeals is a
+    # 2x2 array containing 4 cases overall and we will end up distributing 4 cases rather than 2. Instead, reinstate the
+    # limit here by filtering out the newest cases
+    if genpop == "any"
+      appeals_to_reject = appeals.flatten.sort_by(&:ready_for_distribution_at).drop(limit)
+      appeals = [appeals.first - appeals_to_reject, appeals.last - appeals_to_reject]
+    end
+
     HearingRequestCaseDistributor.new(
       appeals: appeals, genpop: genpop, distribution: distribution, priority: priority
     ).call

app/models/vacols/case_docket.rb

@@ -118,7 +118,7 @@ class DocketNumberCentennialLoop < StandardError; end
         #{JOIN_ASSOCIATED_VLJS_BY_PRIOR_DECISIONS}
       )
       where ((VLJ = ? and 1 = ?) or (VLJ is null and 1 = ?))
-        and rownum <= ?
+        and (rownum <= ? or 1 = ?)
   "
 
   SELECT_NONPRIORITY_APPEALS = "
@@ -324,7 +324,8 @@ def self.distribute_priority_appeals(judge, genpop, limit, dry_run = false)
                                       judge.vacols_attorney_id,
                                       (genpop == "any" || genpop == "not_genpop") ? 1 : 0,
                                       (genpop == "any" || genpop == "only_genpop") ? 1 : 0,
-                                      limit
+                                      limit,
+                                      limit.nil? ? 1 : 0
                                     ])
 
     distribute_appeals(fmtd_query, judge, dry_run)

db/migrate/20200713173228_add_priority_to_distributions.rb

@@ -0,0 +1,10 @@
+class AddPriorityToDistributions < ActiveRecord::Migration[5.2]
+  def up
+    add_column :distributions, :priority_push, :boolean, comment: "Whether or not this distribution is a priority-appeals-only push to judges via a weekly job (not manually requested)"
+    change_column_default :distributions, :priority_push, false
+  end
+
+  def down
+    remove_column :distributions, :priority_push
+  end
+end

db/migrate/20200713174152_backfill_distribution_priority.rb

@@ -0,0 +1,10 @@
+class BackfillDistributionPriority < ActiveRecord::Migration[5.2]
+  disable_ddl_transaction!
+
+  def change
+    Distribution.unscoped.in_batches do |relation|
+      relation.update_all priority_push: false
+      sleep(0.1)
+    end
+  end
+end

db/schema.rb

@@ -10,7 +10,7 @@
 #
 # It's strongly recommended that you check this file into your version control system.
 
-ActiveRecord::Schema.define(version: 2020_07_10_232644) do
+ActiveRecord::Schema.define(version: 2020_07_13_174152) do
 
   # These are extensions that must be enabled in order to support this database
   enable_extension "plpgsql"
@@ -439,6 +439,7 @@
     t.datetime "created_at", null: false
     t.datetime "errored_at", comment: "when the Distribution job suffered an error"
     t.integer "judge_id"
+    t.boolean "priority_push", default: false, comment: "Whether or not this distribution is a priority-appeals-only push to judges via a weekly job (not manually requested)"
     t.datetime "started_at", comment: "when the Distribution job commenced"
     t.json "statistics"
     t.string "status"

docs/schema/caseflow.csv

@@ -323,6 +323,7 @@ distributions,created_at,datetime ∗,x,,,,,
 distributions,errored_at,datetime,,,,,,when the Distribution job suffered an error
 distributions,id,integer (8) PK,x,x,,,,
 distributions,judge_id,integer FK,,,x,,,
+distributions,priority_push,boolean,,,,,,Whether or not this distribution is a priority-appeals-only push to judges via a weekly job (not manually requested)
 distributions,started_at,datetime,,,,,,when the Distribution job commenced
 distributions,statistics,json,,,,,,
 distributions,status,string,,,,,,
@@ -687,18 +688,18 @@ legacy_issues,vacols_sequence_id,integer ∗,x,,,,,The sequence ID of the lega
 legacy_issue_optins,,,,,,,,"When a VACOLS issue from a legacy appeal is opted-in to AMA, this table keeps track of the related request_issue, and the status of processing the opt-in, or rollback if the request issue is removed from a Decision Review."
 legacy_issue_optins,created_at,datetime ∗,x,,,,,"When a Request Issue is connected to a VACOLS issue on a legacy appeal, and the Veteran has agreed to withdraw their legacy appeals, a legacy_issue_optin is created at the time the Decision Review is successfully intaken. This is used to indicate that the legacy issue should subsequently be opted into AMA in VACOLS. "
 legacy_issue_optins,error,string,,,,,,
+legacy_issue_optins,folder_decision_date,date,,,,,,Decision date on case record folder
 legacy_issue_optins,id,integer (8) PK,x,x,,,,
 legacy_issue_optins,legacy_issue_id,integer (8) FK,,,x,,x,"The legacy issue being opted in, which connects to the request issue"
 legacy_issue_optins,optin_processed_at,datetime,,,,,,"The timestamp for when the opt-in was successfully processed, meaning it was updated in VACOLS as opted into AMA."
 legacy_issue_optins,original_disposition_code,string,,,,,,The original disposition code of the VACOLS issue being opted in. Stored in case the opt-in is rolled back.
 legacy_issue_optins,original_disposition_date,date,,,,,,The original disposition date of the VACOLS issue being opted in. Stored in case the opt-in is rolled back.
+legacy_issue_optins,original_legacy_appeal_decision_date,date,,,,,,The original disposition date of a legacy appeal being opted in
+legacy_issue_optins,original_legacy_appeal_disposition_code,string,,,,,,The original disposition code of legacy appeal being opted in
 legacy_issue_optins,request_issue_id,integer (8) ∗ FK,x,,x,,x,The request issue connected to the legacy VACOLS issue that has been opted in.
 legacy_issue_optins,rollback_created_at,datetime,,,,,,"Timestamp for when the connected request issue is removed from a Decision Review during edit, indicating that the opt-in needs to be rolled back."
 legacy_issue_optins,rollback_processed_at,datetime,,,,,,Timestamp for when a rolled back opt-in has successfully finished being rolled back.
 legacy_issue_optins,updated_at,datetime ∗,x,,,,x,Automatically populated when the record is updated.
-legacy_issue_optins,original_legacy_appeal_decision_date,datetime,,,,,,The original disposition date of a legacy appeal being opted in.
-legacy_issue_optins,original_legacy_appeal_disposition_code,string,,,,,,The original disposition code of legacy appeal being opted in.
-legacy_issue_optins,folder_decision_date,date,,,,,,Decision date on case record folder.
 messages,,,,,,,,
 messages,created_at,datetime ∗,x,,,,,
 messages,detail_id,integer FK,,,x,,x,ID of the related object