From 57c8c843d9c21a2ad665e95d5db2ad13c90a9006 Mon Sep 17 00:00:00 2001 From: hschallhorn Date: Wed, 22 Jul 2020 15:27:48 -0400 Subject: [PATCH 1/2] Use appeal.undecided_issues.count for legacy appeals --- app/models/serializers/work_queue/task_column_serializer.rb | 2 +- app/models/serializers/work_queue/task_serializer.rb | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/app/models/serializers/work_queue/task_column_serializer.rb b/app/models/serializers/work_queue/task_column_serializer.rb index ae9cebedb29..7e9cb28a3f8 100644 --- a/app/models/serializers/work_queue/task_column_serializer.rb +++ b/app/models/serializers/work_queue/task_column_serializer.rb @@ -74,7 +74,7 @@ def self.serialize_attribute?(params, columns) columns = [Constants.QUEUE_CONFIG.COLUMNS.ISSUE_COUNT.name] if serialize_attribute?(params, columns) - object.appeal.number_of_issues + object.appeal.is_a?(LegacyAppeal) ? object.appeal.undecided_issues.count : object.appeal.number_of_issues end end diff --git a/app/models/serializers/work_queue/task_serializer.rb b/app/models/serializers/work_queue/task_serializer.rb index 6460997eed0..0f9b3db215b 100644 --- a/app/models/serializers/work_queue/task_serializer.rb +++ b/app/models/serializers/work_queue/task_serializer.rb @@ -105,7 +105,7 @@ class WorkQueue::TaskSerializer end attribute :issue_count do |object| - object.appeal.number_of_issues + object.appeal.is_a?(LegacyAppeal) ? object.appeal.undecided_issues.count : object.appeal.number_of_issues end attribute :external_hearing_id do |object| From fc1f95876140746ac489fc7c26ce8d62eb151ec6 Mon Sep 17 00:00:00 2001 From: hschallhorn Date: Wed, 22 Jul 2020 17:03:17 -0400 Subject: [PATCH 2/2] Fix test --- spec/controllers/tasks_controller_spec.rb | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/spec/controllers/tasks_controller_spec.rb b/spec/controllers/tasks_controller_spec.rb index c5afa5ba3c6..058b1efbdcc 100644 --- a/spec/controllers/tasks_controller_spec.rb +++ b/spec/controllers/tasks_controller_spec.rb @@ -693,7 +693,7 @@ expect(task["attributes"]["appeal_id"]).to eq(legacy_appeal.id) expect(task["attributes"]["available_actions"].size).to eq 2 - expect(DatabaseRequestCounter.get_counter(:vacols)).to eq(13) + expect(DatabaseRequestCounter.get_counter(:vacols)).to eq(14) end end