Use strong_migrations gem #8730
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
Generated by 🚫 Danger |
**Why**: `strong_migrations` is better maintained than `zero_downtime_migrations` and seems to have better advice. The author of the gem has written many other fantastic gems that are used in production at Instacart, so they should be trustworthy. The gem also comes with a handy rake task that will automatically alphabetize the columns in `schema.rb`. This will eliminate issues where after pulling the latest code and running recent migrations locally, your schema.rb will change.
monfresh
force-pushed
the
mb-strong-migrations
branch
from
6b46045
to
0e95d39
Compare
anyakhvost
reviewed
Jan 15, 2019
| @@ -0,0 +1 @@ | |||
| StrongMigrations.start_after = 20190111000717 | |||
anyakhvost
approved these changes
Jan 15, 2019
monfresh
added
Ready-to-Merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why:
strong_migrationsis better maintained thanzero_downtime_migrationsand seems to have better advice. The authorof the gem has written many other fantastic gems that are used in
production at Instacart, so they should be trustworthy.
The gem also comes with a handy rake task that will automatically
alphabetize the columns in
schema.rb. This will eliminate issueswhere after pulling the latest code and running recent migrations
locally, your schema.rb will change.