From 63b035f164ed42ae2c0d48d1179bfaa91eecfc12 Mon Sep 17 00:00:00 2001 From: Tim R Date: Tue, 14 May 2024 13:11:05 -0500 Subject: [PATCH 1/3] Fix TS complaint --- packages/components/src/components/Icon/Icon.tsx | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/packages/components/src/components/Icon/Icon.tsx b/packages/components/src/components/Icon/Icon.tsx index 04e5523e..c5381fff 100644 --- a/packages/components/src/components/Icon/Icon.tsx +++ b/packages/components/src/components/Icon/Icon.tsx @@ -211,7 +211,8 @@ export const Icon: FC = ({ const fontScale = useWindowDimensions().fontScale const fs = (val: number) => fontScale * val - const _Icon: FC = name ? IconMap[name] : svg + // ! to override TS incorrectly thinking svg can be undefined after update + const _Icon: FC = name ? IconMap[name] : svg! if (typeof fill === 'object') { fill = isDarkMode ? fill.dark : fill.light From 53d36acc3f40ff447fc66738fe30445a1d3b2f6a Mon Sep 17 00:00:00 2001 From: VA Automation Bot Date: Tue, 14 May 2024 20:17:26 +0000 Subject: [PATCH 2/3] Version bump: components-v0.15.3 --- packages/components/package.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/components/package.json b/packages/components/package.json index c87c7c3d..65127645 100644 --- a/packages/components/package.json +++ b/packages/components/package.json @@ -1,6 +1,6 @@ { "name": "@department-of-veterans-affairs/mobile-component-library", - "version": "0.15.2", + "version": "0.15.3", "description": "VA Design System Mobile Component Library", "main": "src/index.tsx", "scripts": { From d4e82d45afb38e006b563d51a3094fa34ce8f866 Mon Sep 17 00:00:00 2001 From: VA Automation Bot Date: Tue, 14 May 2024 20:17:36 +0000 Subject: [PATCH 3/3] Changelog for components-v0.15.3 --- CHANGELOG.md | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index b5a100aa..b03847fe 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -1,5 +1,13 @@ # Changelog +## [components-v0.15.3](https://github.com/department-of-veterans-affairs/va-mobile-library/tree/components-v0.15.3) (2024-05-14) + +[Full Changelog](https://github.com/department-of-veterans-affairs/va-mobile-library/compare/components-v0.15.2...components-v0.15.3) + +**Merged pull requests:** + +- \[Bug\] Fix TS complaint in Icon [\#318](https://github.com/department-of-veterans-affairs/va-mobile-library/pull/318) ([TimRoe](https://github.com/TimRoe)) + ## [components-v0.15.2](https://github.com/department-of-veterans-affairs/va-mobile-library/tree/components-v0.15.2) (2024-05-14) [Full Changelog](https://github.com/department-of-veterans-affairs/va-mobile-library/compare/components-v0.15.1...components-v0.15.2)