Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Markup and meta data] HTML markup isn't valid. (09.01.1) #34163

Closed
2 tasks
shiragoodman opened this issue Dec 15, 2021 · 10 comments
Closed
2 tasks

[Markup and meta data] HTML markup isn't valid. (09.01.1) #34163

shiragoodman opened this issue Dec 15, 2021 · 10 comments
Assignees
Labels
a11y-defect-2 High-severity accessibility issue that should be fixed in the next 1 - 2 sprints accessibility CC-Dashboard To be included in Collab Cycle Dashboard CCIssue09.01 collab-cycle-feedback For VSP Collaboration cycle feedback assigned to VFS frontend Public Websites Global Unauthenticated Experience team for va.gov. Products include home page, content hubs... Staging

Comments

@shiragoodman
Copy link
Contributor

General Information

VFS team name

Debt Resolution

VFS product name

Medical Copays (MCP)

Point of Contact/Reviewers

Noah Gelman (@noahgelman) - Accessibility


Platform Issue

HTML markup isn't valid.

Issue Details

The value of an ARIA ID must be unique to prevent other instances from being overlooked by assistive technologies.Failing Elements My VAMy HealthProfileSign Out

- Sarah Koomson

Link, screenshot or steps to recreate

https://googlechrome.github.io/lighthouse/viewer/

VA.gov Experience Standard

Category Number 09, Issue Number 01

Other References

WCAG SC 1.3.1_A


Platform Recommendation

In order to prevent invalid markup, a unique ID must be implemented, so JAWS/NVDA does not overlook the second instance. Could possibly use - "id="MYVA-account-menu", "id="MyHealth-account-menu", etc/

VFS Team Tasks to Complete

  • Comment on the ticket if there are questions or concerns
  • Close the ticket when the issue has been resolved or validated by your Product Owner. If a team has additional questions or needs Platform help validating the issue, please comment in the ticket.
@shiragoodman shiragoodman added a11y-defect-2 High-severity accessibility issue that should be fixed in the next 1 - 2 sprints accessibility CC-Dashboard To be included in Collab Cycle Dashboard CCIssue09.01 collab-cycle-feedback For VSP Collaboration cycle feedback assigned to VFS Staging vsa-debt Benefits Team 2 (formerly Debt Resolution,Benefits and Memorials 2) labels Dec 15, 2021
@craigwheeler craigwheeler added MCP Medical Co-pays MVP frontend labels Jan 4, 2022
@craigwheeler
Copy link
Contributor

hey @noahgelman I saw you were listed as a point of contact on this ticket so wanted to reach out to verify what the issue is here? The ticket states there's an issue with some aria id but isn't too clear on where the issue was reported or what should be updated? I've also verified any aria tags used are unique so maybe not an issue anymore?

@shiragoodman
Copy link
Contributor Author

@craigwheeler - Noah is out sick today but I'll be sure he see's this when he returns. Did you see the Platform Recommendation section above? There's additional details on the issue.

@craigwheeler
Copy link
Contributor

hey @shiragoodman thanks! yep I saw the platform recommendation but the suggestion is to add id="MYVA-account-menu (add to what i dunno?) and the only instance of account-menu I can find relates to the sign in profile menu which is where i'm confused on what should be updated with MCP?

@shiragoodman
Copy link
Contributor Author

@craigwheeler The Staging Review for Medical Copays is tomorrow at 11:30am ET so feel free to ask for clarification then. If Noah is out sick still, we have a couple other accessibility specialists that will be in attendance :)

@noahgelman
Copy link
Contributor

@shiragoodman @craigwheeler I'll get clarification on this and report back

@craigwheeler
Copy link
Contributor

spoke with the accessibility team during staging review and verified this is an issue with the header and was asked to leave the ticket in backlog for them to address it at a later time

@craigwheeler
Copy link
Contributor

it appears that the issue highlighted for this ticket occurs in the sign in profile widget for account-menu found here:

Screen Shot 2022-01-27 at 9.29.46 AM.png

@shiragoodman shiragoodman added Public Websites Global Unauthenticated Experience team for va.gov. Products include home page, content hubs... and removed vsa-debt Benefits Team 2 (formerly Debt Resolution,Benefits and Memorials 2) labels Jan 27, 2022
@shiragoodman
Copy link
Contributor Author

@denisecoveyduc @brianalloyd I have removed the vsa-debt team label and added the public websites label. Brian and team are going to investigate the issue and determine a solution. If the issue ends up being the responsibility of another team, please let me know and I will get it reassigned. Thanks both!

@sara-amanda
Copy link
Contributor

Two tickets relating to this issue noted in comments of the respective tickets. Details in #54863 @briandeconinck @joshkimux @coforma-terry

@laflannery
Copy link
Contributor

I cannot replicate this any more. We are also in the process of rebuilding the header so I am going to make sure there aren't any duplicate IDs in the new implementation. I'm going to close this due to those reasons but if anyone feels like it should be reopened please let me know

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a11y-defect-2 High-severity accessibility issue that should be fixed in the next 1 - 2 sprints accessibility CC-Dashboard To be included in Collab Cycle Dashboard CCIssue09.01 collab-cycle-feedback For VSP Collaboration cycle feedback assigned to VFS frontend Public Websites Global Unauthenticated Experience team for va.gov. Products include home page, content hubs... Staging
Projects
None yet
Development

No branches or pull requests

7 participants