Skip to content
Permalink
Branch: master
Commits on Oct 31, 2019
  1. vet360 address override (#3493)

    lihanli committed Oct 31, 2019
    * record override cassette
    
    * complete put_address_override spec
    
    * add factory for address with validation key
    
    * record cass from controller
    
    * get validation key first
    
    * update validation key
    
    * update cassette to work with controller
    
    * fix contact info service spec
    
    * add validaton key to swagger
    
    * lint
Commits on Oct 25, 2019
  1. Log vet360 address errors (#3457)

    lihanli committed Oct 25, 2019
    * record address error
    
    * log vet360 address update errors
    
    * lint
Commits on Oct 23, 2019
  1. vet360 address validation endpoint (#3441)

    lihanli committed Oct 23, 2019
    * add address validation service and config
    
    * add api key to address validation header
    
    * address validation service spec stub
    
    * fix city_state_province get
    
    * use settings hostname for vet360 url
    
    * pry before sending req
    
    * use address validation hostname
    
    * add address_validation_req method to vet360 address model
    
    * testing candidate api
    
    * testing candidate api
    
    * dont need country name
    
    * add sample address
    
    * add cassette for candidate api one match
    
    * use match everything for candidate_one_match cassette
    
    * format candidate address response
    
    * record invalid addr
    
    * add candiddate no match cassette
    
    * working on addr validation controller
    
    * dont send address pou in address validation req
    
    * rerecord candidate no match
    
    * update candidate_no_match.yml cassette
    
    * add deep_remove_blanks helper
    
    * address valid controller create spec with one match
    
    * controller spec for invalid address
    
    * invalid address service spec
    
    * add todos
    
    * multiple suggestions
    
    * add validate endpoint
    
    * record cass for invalid addr to validate api
    
    * validate no match cassette
    
    * handle_error for validate method
    
    * validate match record
    
    * add address suggestions method
    
    * use match everything for validate_match
    
    * add multiple match addr to factory
    
    * fix addr valid controller spec
    
    * change params for addr valid controller
    
    * address validation swagger
    
    * add lengths for zip code and zip code suffix
    
    * fix specs
    
    * lint
    
    * lint
    
    * add configuration.rb to coverage filter
Commits on Oct 15, 2019
  1. log ssn in user metadata for ppiu errors (#3401)

    lihanli committed Oct 15, 2019
Commits on Oct 3, 2019
  1. PPIU error logging (#3366)

    lihanli committed Oct 3, 2019
    * create pii log on ppiu error
    
    * use different method for saving req body
    
    * lint
    
    * lint
    
    * dont use instance variables for log_exception
    
    * rename save_req_body
Commits on Sep 23, 2019
  1. Direct deposit sentry filter (#3304)

    lihanli committed Sep 23, 2019
    * working on filter feq body spec
    
    * finilsh filter req body spec
    
    * lint
    
    * use dig for stringified data
    
    * use dig for sanitized data
    
    * add sanitize method
    
    * change spec to with data from a controller in FILTERED_CONTROLLER
    
    * change data variable to sentry data
    
    * Refactor the specs for clarity (#3329)
    
    * Duplicate existing specs
    
    * Remove previous specs
    
    * Promote client and processor to before(:each)
    
    * Refactor sentry setup into method
    
    * Parameterize method with focus of spec, rename for clarity
    
    * Wordsmithing
Commits on Sep 20, 2019
  1. require users to have multifactor and loa3 for ppiu access (#3285)

    lihanli committed Sep 20, 2019
    * require users to have multifactor and loa3 for ppiu access
    
    * add spec for unauthorized user
Commits on Sep 17, 2019
  1. email a user's identity and vet360 email addresses when dd info is ch…

    lihanli committed Sep 17, 2019
    …anged (#3296)
    
    * all emails method
    
    * use all_emails in ppiu controller
    
    * lint
Commits on Sep 4, 2019
  1. log user uuid when a user authenticates (#3240)

    lihanli committed Sep 4, 2019
    * log user uuid
    
    * set user_uuid to nil if current user is nil
    
    * unset log tags in after_action
    
    * log user uuid after finding user
    
    * dont need thread variable for user uuid
    
    * use payload to log user uuid
  2. Update how service members are handled for HCA status (#3146)

    lihanli committed Sep 4, 2019
    * add eligibilities to ee service
    
    * only need to check primary elig and veteran indicator
    
    * use eligiblity code and veteran status for active duty status
    
    * add non military status
    
    * fix notification spec
    
    * lint
    
    * lint
Commits on Aug 30, 2019
  1. increase ppiu timeout (#3255)

    lihanli committed Aug 30, 2019
Commits on Aug 29, 2019
  1. rescue vet 360 errors in current_user_email (#3241)

    lihanli committed Aug 29, 2019
Commits on Aug 26, 2019
  1. fix ip-address and useragent logging (#3234)

    lihanli committed Aug 26, 2019
    * fix remote ip and user agent logging in sidekiq
    
    * lint
Commits on Aug 8, 2019
  1. separate test db and production db (#3191)

    lihanli and jholton committed Aug 8, 2019
    * separate test db
    
    * add test_database_url
    
    * add test_database_url to docker compose
    
    * Update config/database.yml
    
    Co-Authored-By: Johnny Holton <johnny@oddball.io>
Commits on Aug 1, 2019
  1. log vet360 request bodies (#3183)

    lihanli committed Aug 1, 2019
    * log vet360 request bodies
    
    * log dates instead of full body
Commits on Jul 10, 2019
  1. update json schema (#3147)

    lihanli committed Jul 10, 2019
Commits on Jun 25, 2019
  1. handle nil form in user attributes method (#3114)

    lihanli committed Jun 25, 2019
  2. Hca attachment bug (#3124)

    lihanli committed Jun 25, 2019
    * get file extension from content type and add to file metadata
    
    * add non pdf attachment spec
    
    * turn off verify for record
    
    * add get_va_format method
    
    * add vcr cassette for submit with attach jpg
    
    * turn verify true on
Commits on May 30, 2019
  1. Emis attribute docs (#3066)

    lihanli committed May 30, 2019
    * emis service docs
    
    * create_edipi_or_icn_message doc
    
    * emis config ssl paths docs
    
    * connection docs
    
    * allow missing certs docs
    
    * MilitaryInformationConfiguration docs
    
    * MilitaryInformationConfiguration docs
    
    * MilitaryInformationService docs
    
    * payment config docs
    
    * payment service docs
    
    * veteran status config docs
    
    * veteran status service docs
    
    * edipi message docs
    
    * combat pay docs
    
    * deployment docs
    
    * deployment location docs
    
    * disability docs
    
    * guard reserve docs
    
    * military occupation docs
    
    * mse docs
    
    * military service episodes docs
    
    * emis model docs
    
    * emis error response docs
    
    * combat pay response docs
    
    * get deployment response docs
    
    * emis response docs
    
    * build item docs
    
    * locate one docs
    
    * find_all_elements_by_tag_name docs
    
    * working on military information docs
    
    * military information docs
    
    * emis redis model data
    
    * emis redis veteran status docs
    
    * dont need returns in boolean return docs
    
    * lint
    
    * capitalize
    
    * remove returns from booleans
    
    * remove periods
    
    * emis combat pay type code
    
    * combat pay combat_zone_country_code
    
    * add whitespace
    
    * working on deployment attributes
    
    * use newlines instead of ignoring trailing whitespace
    
    * deployment attribute docs
    
    * deployment location docs
    
    * disability docs
    
    * working on GuardReserveServicePeriod docs
    
    * use code blocks for all codes
    
    * guard reserve docs
    
    * military occupation docs
    
    * use links for project code
    
    * military service episode docs
    
    * military service eligib info docs
    
    * reserve drill days docs
    
    * retirement docs
    
    * retirement pay docs
    
    * separation pay docs
    
    * unit info docs
    
    * veteran status docs
    
    * lint
    
    * use code block for termination_reason
Commits on May 28, 2019
  1. Rails 5.2.3 (#2933)

    lihanli authored and kfrz committed May 28, 2019
    * Upgrade rails to 5.2.3
    
    * Replace `be_success` with `be_successful` in specs for readability
Commits on May 15, 2019
  1. add monitoring to hca ee api (#3042)

    lihanli committed May 15, 2019
Commits on May 10, 2019
  1. hca ee load test rake task (#3031)

    lihanli committed May 10, 2019
    * add load test task
    
    * add desc
Commits on May 1, 2019
  1. Rails 5.1 (#2897)

    lihanli authored and kreek committed May 1, 2019
    * Update locale modules/**/*.gemspec to point to rails 5.0.7.1
    
    * Update modules meta information to point to va.gov
    
    * Update activerecord-postgis-adapter version to >= 4.0.x
    
    * Update nokogiri version to >= 1.10.1
    
    * Add initializers as suggested by the rails app:update command
    
    * Disable config.action_controller.raise_on_unfiltered_parameters setting
    
    * Update models to inherit from ApplicationRecord
    
    * update database type cast for clean uuid
    
    * dont send strings for hash attributes
    
    * add deep transform parameters method in app controller
    
    * Add utf8-cleaner gem
    
    * Rails 5.0.0 introduced code in ActionDispatch to catch invalid
      UTF-8 querystring params, and raise a ActionController::BadRequest
      error when present. For more information, see the commit at:
      rails/rails@59ab2d1#diff-a2247cc200a3f9cd3d0e5ef8d76c4df8
    
    * utf8-cleaner gem introduces a middleware layer to rack requests
      that will sanitize rack input, avoiding UTF8 errors altogether
    
    * Remove #safe_encoded_params from GI::InstitutionsController
    
    * Update specs to expect a successful request if sent invalid UTF8
    string, as it should be sanitized by rack
    
    * Update module callbacks to declare raise: false
    
    * Refactor UsersController test to use consistent matcher
    
    * Assign id param in V0::Facilities::CcpController#validate_id instead of mutating it
    
    * Pin mail gem to 2.6.6 to avoid generating LF characters
    
    * Revert nokogiri uptick, save for another pr
    
    * Uptick rubocop target rails version
    
    * move deep transform parameters out of app controller (#2842)
    
    * Update migrations to specify from which Rails version they were spawned
    
    * turn on belongs_to_required_by_default
    
    * move deep transform parameters out of app controller
    
    * remove raise in transactional callbacks
    
    * permit all on MessagingPreferencesController
    
    * dont need to return false if error is added
    
    * permit params in pciu controller
    
    * permit in health records ctrl
    
    * permit params for military ranks ctrl
    
    * use to hash in prescriptions finder
    
    * update attr encrypted
    
    * make mhv account relationship optional
    
    * saved claim on persistent attach optional
    
    * validate presence of auth headers json
Commits on Apr 30, 2019
  1. Emis yard docs (#3011)

    lihanli committed Apr 30, 2019
    * emis service docs
    
    * create_edipi_or_icn_message doc
    
    * emis config ssl paths docs
    
    * connection docs
    
    * allow missing certs docs
    
    * MilitaryInformationConfiguration docs
    
    * MilitaryInformationConfiguration docs
    
    * MilitaryInformationService docs
    
    * payment config docs
    
    * payment service docs
    
    * veteran status config docs
    
    * veteran status service docs
    
    * edipi message docs
    
    * combat pay docs
    
    * deployment docs
    
    * deployment location docs
    
    * disability docs
    
    * guard reserve docs
    
    * military occupation docs
    
    * mse docs
    
    * military service episodes docs
    
    * emis model docs
    
    * emis error response docs
    
    * combat pay response docs
    
    * get deployment response docs
    
    * emis response docs
    
    * build item docs
    
    * locate one docs
    
    * find_all_elements_by_tag_name docs
    
    * working on military information docs
    
    * military information docs
    
    * emis redis model data
    
    * emis redis veteran status docs
    
    * dont need returns in boolean return docs
    
    * lint
    
    * capitalize
    
    * remove returns from booleans
    
    * remove periods
Commits on Apr 25, 2019
Commits on Apr 19, 2019
  1. hca backend statuses missing inelig_other (#2979)

    lihanli committed Apr 19, 2019
    * add inelig other category
    
    * lint
    
    * alphabetize list
Commits on Apr 16, 2019
  1. Rails 5.1 belongs to changes (#2964)

    lihanli committed Apr 16, 2019
    * belongs to changes
    
    * 526 submission fact fix
Commits on Apr 12, 2019
  1. Preneeds schema fix (#2960)

    lihanli authored and wyattwalter committed Apr 12, 2019
Commits on Apr 10, 2019
  1. support new gibft schema keys (#2941)

    lihanli committed Apr 10, 2019
    * add new schema keys to feedback mappings
    
    * spec for new gibft schema key
Commits on Apr 4, 2019
  1. HCA handle nil enrollment_status for loa3 users (#2924)

    lihanli committed Apr 4, 2019
    * handle nil enrollment status
    
    * lint
    
    * move category_matcher to separate function
Commits on Apr 2, 2019
  1. Bug in School Feedback Form Submissions (#2921)

    lihanli committed Apr 2, 2019
    * remove malformed options method
    
    * transform malformed options method
    
    * fix transform form
    
    * malformed options spec
    
    * lint
    
    * make fixing options methods private
    
    * use reject in remove malformed options
    
    * dont need to loop in fix_options method
    
    * lint
Commits on Mar 15, 2019
  1. dont rescue all mvi errors (#2873)

    lihanli committed Mar 15, 2019
Commits on Mar 13, 2019
  1. Hca e&e api loa1 user changes (#2870)

    lihanli committed Mar 13, 2019
    * only use user icn if user is loa3
    
    * parse ee data differently for non loa3 users
    
    * pass in loa3 var from controller
    
    * parsed ee data method with loa3 user spec
    
    * parsed_ee_data loa1 user spec
    
    * fix hca request spec
    
    * lint
    
    * fix swagger spec
  2. Update rails gems because of security vulnerabilities (#2871)

    lihanli committed Mar 13, 2019
    * update rails to 4.2.11.1
    
    * ignore CVE-2019-5420 because it can only be fixed by updating to rails 5.2 and can only affect a server running in development mode
Commits on Mar 11, 2019
  1. Hca user attr change (#2867)

    lihanli committed Mar 11, 2019
    * dont validate inclusion of gender
    
    * return none of the above if enrollment status is blank
    
    * return different parsed status for non loa3 users
    
    * Revert "return different parsed status for non loa3 users"
    
    This reverts commit 65356ff.
    
    * Revert "return none of the above if enrollment status is blank"
    
    This reverts commit bb8e6ee.
    
    * remove gender from hca user attrs
    
    * fix user attrs spec
    
    * add gender method to user attrs so that message_user_attributes will work
    
    * record new episode
    
    * update attr service vcr
    
    * fix rate limited search spec
Older
You can’t perform that action at this time.