Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DBEX] create UploadStatusUpdater PORO #17439

Merged
merged 7 commits into from
Jul 10, 2024

Conversation

freeheeling
Copy link
Contributor

@freeheeling freeheeling commented Jul 8, 2024

Summary

Objective: Implements a system for periodically polling the Lighthouse uploads/status endpoint to confirm the status of supplemental documents submitted to Lighthouse as part of a Form 526 Submission. The purpose of this system is to surface successes and failures that happen in the Form 526 process after being forwarded to Lighthouse for processing.

  • Create UploadStatusUpdater PORO
    • encapsulates parsing of complex nested response from Lighthouse Benefits Documents API 'uploads/status' endpoint
    • provides convenience methods for verifying whether a document has completed all processing, failed processing, or transitioned to another step in the process
  • Subsequent PRs will further implement the interaction with the Lighthouse Benefits Document API client
  • This work is behind a feature toggle (flipper): YES/NO
  • Responsible team: Disability Benefits Experience Team 2 (dBeX Carbs 🥖)

Related issue(s)

Testing done

  • New code is covered by unit tests

What areas of the site does it impact?

  • non-user facing, asynchronous job tracking the status of uploaded documents submitted in conjunction with Form 526EZ

Acceptance criteria

  • I fixed|updated|added unit tests and integration tests for each feature (if applicable).
  • No error nor warning in the console.
  • Events are being sent to the appropriate logging solution
  • Documentation has been updated (link to documentation)
  • No sensitive information (i.e. PII/credentials/internal URLs/etc.) is captured in logging, hardcoded, or specs
  • Feature/bug has a monitor built into Datadog (if applicable)
  • If app impacted requires authentication, did you login to a local build and verify all authenticated routes work as expected
  • I added a screenshot of the developed feature

@freeheeling freeheeling added disability-experience To manage benefits disability claims experience. disability-compensation Label used for Pull Requests that impact Disability Compensation claims (526EZ) labels Jul 8, 2024
Copy link

github-actions bot commented Jul 8, 2024

1 Warning
⚠️ This PR changes 283 LoC (not counting whitespace/newlines).

In order to ensure each PR receives the proper attention it deserves, we recommend not exceeding
200. Expect some delays getting reviews.

File Summary

Files

  • lib/lighthouse/benefits_documents/form526/upload_status_updater.rb (+118/-0)

  • spec/lib/lighthouse/benefits_documents/form526/upload_status_updater_spec.rb (+165/-0)

    Note: We exclude files matching the following when considering PR size:

    *.csv, *.json, *.tsv, *.txt, Gemfile.lock, app/swagger, modules/mobile/docs, spec/fixtures/, spec/support/vcr_cassettes/, modules/mobile/spec/support/vcr_cassettes/, db/seeds, modules/vaos/app/docs, modules/meb_api/app/docs, modules/appeals_api/app/swagger/, *.bru
    

Big PRs are difficult to review, often become stale, and cause delays.

Generated by 🚫 Danger

@freeheeling freeheeling force-pushed the dbex/86719-create-upload-status-updater branch from cf80418 to b5baea6 Compare July 9, 2024 15:33
@va-vfs-bot va-vfs-bot temporarily deployed to dbex/86719-create-upload-status-updater/main/main July 9, 2024 16:01 Inactive
@va-vfs-bot va-vfs-bot temporarily deployed to dbex/86719-create-upload-status-updater/main/main July 9, 2024 16:38 Inactive
@va-vfs-bot va-vfs-bot temporarily deployed to dbex/86719-create-upload-status-updater/main/main July 9, 2024 17:52 Inactive
@freeheeling freeheeling merged commit 6595cda into master Jul 10, 2024
19 checks passed
@freeheeling freeheeling deleted the dbex/86719-create-upload-status-updater branch July 10, 2024 21:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
disability-compensation Label used for Pull Requests that impact Disability Compensation claims (526EZ) disability-experience To manage benefits disability claims experience.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants