Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider adding an ASIDE component to the design system #258

Closed
1 task done
1Copenut opened this issue Jul 13, 2020 · 8 comments
Closed
1 task done

Consider adding an ASIDE component to the design system #258

1Copenut opened this issue Jul 13, 2020 · 8 comments
Labels
component-new Proposed new component documentation-REACT Updates to REACT documentation and code help wanted Extra attention is needed platform-design-system-team

Comments

@1Copenut
Copy link
Contributor

1Copenut commented Jul 13, 2020

Feature Request

  • I’ve searched for any related issues and avoided creating a duplicate issue.

Is this feature request relating to an existing component or utility? Please describe.

  • Component/utility name: Aside

Do you have a suggestion for a new component or utility?

Jesse on the eBenefits team has created two important items for this component

Additional context

I (Trevor) am trying to work this into our council process, with the understanding it hasn't been socialized to developers yet. I need additional help to decide if this is a component we want to add to the design system, and to make sure it's feature-complete before being merged and put into production.

I have added myself to the pull request and have some changes to suggest, and would like to see documentation thought out for the aside. At a minimum:

  • Asides MUST NOT live inside the <main> component, but as a peer
  • Headings MUST be able to be changed, otherwise we run the risk of more hard-coded heading levels skipping around incorrectly
  • Asides SHOULD have clear guidance for content and when to consider moving things into the main content area.

/cc @KevinMHoffmanUSDS && @CrystabelReiter

@1Copenut 1Copenut added help wanted Extra attention is needed documentation-REACT Updates to REACT documentation and code component-new Proposed new component labels Jul 13, 2020
@1Copenut 1Copenut added this to Proposals (New or Update) in Design System Governance Process (WIP) Jul 13, 2020
@1Copenut
Copy link
Contributor Author

1Copenut commented Jul 28, 2020

Cross-linking @sporeboy comment from VA.gov issue 2172:

Regarding content in the RH column:

We will be conducting usability testing on the View Payment History feature in the coming sprints. Additionally, the VA Debt Letters feature being developed by BAM2(?) has a RH column and will be tested. We were originally pointed to the Claim Status Tool (BAM1?) as a model; I can't find their research.

@1Copenut 1Copenut moved this from Proposals (New or Update) to Design System Council Review in Design System Governance Process (WIP) Aug 5, 2020
@1Copenut
Copy link
Contributor Author

1Copenut commented Aug 5, 2020

@cohnjesse
Copy link
Contributor

Here is a mobile screenshot. You can also take a look at all of the places the sidebar is used on VA.gov, it is used on lots of pages and this sidebar component is only meant to make these reusable in code and NOT to restyle them in some new way.

Screen Shot 2020-08-06 at 10 48 56 AM

@sshein
Copy link
Contributor

sshein commented Aug 6, 2020

ooh so is this going to be tested again soon with "View Payments" @sporeboy? BAM2 ended up changing their design to not include the right rail. If it's going to be tested again soon make sure to include me when writing the conversation guide and chatting about the study

@sshein
Copy link
Contributor

sshein commented Aug 6, 2020

when you say "it is used on lots of pages" @cohnjesse are there others you've identified besides Claim Status Tool and the tools that you all have created on eBenefits? Just so I'm aware of the places we have it currently and can inform folks. I remember the history here when Jeff Barnes initially brought it up as a design he wanted the team to use.

@sshein
Copy link
Contributor

sshein commented Aug 6, 2020

ah it's on Search too https://www.va.gov/search/?query=agent+orange

@KevinMHoffmanUSDS
Copy link
Contributor

Note: guidelines are being developed by @rtwell and @sshein as per #160 (comment)

@KevinMHoffmanUSDS KevinMHoffmanUSDS moved this from Design System Council Review to Design System Council Reviewed in Design System Governance Process (WIP) Aug 24, 2020
@KevinMHoffmanUSDS KevinMHoffmanUSDS moved this from Design System Council Reviewed to Design System Council Review in Design System Governance Process (WIP) Nov 19, 2020
@humancompanion-usds
Copy link
Collaborator

In #160 it was decided to not create a component for aside. We'll use #160 for future work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component-new Proposed new component documentation-REACT Updates to REACT documentation and code help wanted Extra attention is needed platform-design-system-team
Projects
Design System Governance Process (WIP)
  
Design System Council Review
Development

No branches or pull requests

6 participants