New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use commit type `build` instead of `chore` #255

Closed
Kocal opened this Issue Nov 7, 2018 · 3 comments

Comments

Projects
None yet
2 participants
@Kocal

Kocal commented Nov 7, 2018

Hello, I'm opening this issue following #53 and #186 (comment).

How can we configure Dependabot to always use build commit type?

By reading message_builder.rb, it seems that use recent commits and last Dependabot commit to determine build or chore right?

In my case I don't understand the behavior:
selection_999 140

Since this is the first Dependabot PR, it determine commit type from PR 3 5 and 6 right? But those PR are not about updating dependencies... 🤔

If for the future I want Dependabot to use build commit type, I should rebase and edit the commit message?
selection_999 141

But what will happens if I commit with chore(...):?
Does Dependabot will use chore again? 🤔

Thank you!

@greysteil

This comment has been minimized.

Member

greysteil commented Nov 7, 2018

Ah, interesting, and slightly tricky. Dependabot is trying to work around the fact that there are two Angular guides for commit messages: one that allows chore but disallows build, and another that allows build but disallows chore. Sounds like we're not doing a good job for people who use both chore and build!

I'm going to rejig the logic so that Dependabot always prioritises its last commit message. Once that's done (will be deployed in 10 minutes) if you edit the commit message of the last Dependabot commit on your repo then it will stick to that.

Longer term it looks like we are going to have to make this configurable as a setting - some folks want Build. 😭

@greysteil greysteil closed this Nov 7, 2018

@greysteil

This comment has been minimized.

Member

greysteil commented Nov 7, 2018

Fix deploying!

@Kocal

This comment has been minimized.

Kocal commented Nov 7, 2018

Thank you, you rocks! 🎉 😜

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment