Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Adding SublimeLinter Colorization #31

Merged
merged 2 commits into from Sep 20, 2012

Conversation

Projects
None yet
2 participants
Contributor

Iristyle commented Aug 14, 2012

Using various base colors as outlines, red underline for errors, orange underline for violations, yellow underline for warnings.

These colors are consistent with the official Solarized colors

base03: #002b36
base02: #073642
base01: #586e75
base00: #657b83
base0: #839496
base1: #93a1a1
base2: #eee8d5
base3: #fdf6e3
yellow: #b58900
orange: #cb4b16
red: #dc322f
magenta: #d33682
violet: #6c71c4
blue: #268bd2
cyan: #2aa198
green: #859900

@Iristyle Iristyle Adding SublimeLinter colorization
Using various base colors as outlines, red underline for errors, 
orange underline for violations, yellow underline for warnings
77c2660
Owner

deplorableword commented Aug 15, 2012

Could these be added to the light theme as well?

Contributor

Iristyle commented Aug 15, 2012

Sure --- are you cool with the same red / orange / yellow colorizations on that side of the fence?

(BTW - I'm also going to fix the remaining out-of-spec colors today -- have figured out what colors should be replaced, just have to check on a few test files to be sure)

Owner

deplorableword commented Aug 15, 2012

Any chance you could throw up a quick screenshot? I don't have TM setup correctly on this machine. Thanks for figuring out the incorrect colours :)

@Iristyle Iristyle Adding SublimeLinter colorization
Updated light theme with the same changes as the dark theme

Using various base colors as outlines, red underline for errors, 
orange underline for violations, yellow underline for warnings
5a5de06
Contributor

Iristyle commented Aug 15, 2012

I created a gist demonstrating the differences in colors for underlines, etc:

https://gist.github.com/3360526

This should be pull-ready. I will create a new branch / pull request for standardizing the other colors.

Contributor

Iristyle commented Sep 20, 2012

Likewise, was hoping that these additions could be accepted.

I was able to get this repo accepted into the feed for Sublime Package Control, so this is the repo now for Sublime.... I'd rather not have to fork / maintain a separate copy.

Owner

deplorableword commented Sep 20, 2012

Sorry, I've out of the mix and have switched machines. These look good, I'll merge in.

In terms of this being the repo for Sublime now, that's great. Do you want to fork the readme and add in any relevant details that sublime text users might need to know?

@deplorableword deplorableword added a commit that referenced this pull request Sep 20, 2012

@deplorableword deplorableword Merge pull request #31 from Iristyle/master
Adding SublimeLinter Colorization
056c6e3

@deplorableword deplorableword merged commit 056c6e3 into deplorableword:master Sep 20, 2012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment