From 1fb2d6f3cddf03348de6751717f102d92cc34314 Mon Sep 17 00:00:00 2001
From: Dominik Schilling <dominikschilling+git@gmail.com>
Date: Mon, 30 Jan 2023 21:19:57 +0100
Subject: [PATCH] Simplify loop in releases_list (#3471)

* Avoid calling count() in loop
* Remove extra variable for release name
* Reverse the array before for clarity
---
 recipe/deploy/release.php | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/recipe/deploy/release.php b/recipe/deploy/release.php
index 8215bdc09..748b50994 100644
--- a/recipe/deploy/release.php
+++ b/recipe/deploy/release.php
@@ -42,13 +42,13 @@
         return basename(rtrim(trim($release), '/'));
     }, $ll);
 
-    $releasesLog = get('releases_log');
+    // Return releases from newest to oldest.
+    $releasesLog = array_reverse(get('releases_log'));
 
     $releases = [];
-    for ($i = count($releasesLog) - 1; $i >= 0; --$i) {
-        $release = $releasesLog[$i]['release_name'];
-        if (in_array($release, $ll, true)) {
-            $releases[] = $release;
+    foreach ($releasesLog as $release) {
+        if (in_array($release['release_name'], $ll, true)) {
+            $releases[] = $release['release_name'];
         }
     }
     return $releases;