-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Automatic registration of server env vars #272
Conversation
…e and port) to the Builder class.
It's fail down because of (BuilderTest.php#L115)[https://github.com/deployphp/deployer/blob/master/test/src/Server/BuilderTest.php#L115] |
I think it should be okay now. |
Please, before i merge this PR, add docs to deployphp/docs too. Thank a lot! |
Now we need set as private here. |
I had to redo this due to incompatibilities with the resent changes. |
Refactored PR based on #272 (automatic setting of the "server" env var)
I implemented the solution we aggreed upon in issue #270.
The problem is, that it breaks an existing test, and I can't figure out why.
Can someone help me out with this?
(If this issue is resolved I'll add tests for the new functionality too.)
Here's the output of phpunit: