From 14c870bcf8d56c390c2e2d909a4d10bf2d578ba9 Mon Sep 17 00:00:00 2001 From: michael-siek Date: Thu, 20 Apr 2023 08:39:15 -0400 Subject: [PATCH 1/4] fix(capybara): open browser based on passed symbol --- packages/axe-core-capybara/lib/axe-capybara.rb | 2 +- packages/axe-core-capybara/spec/axe-capybara_spec.rb | 8 +++++++- 2 files changed, 8 insertions(+), 2 deletions(-) diff --git a/packages/axe-core-capybara/lib/axe-capybara.rb b/packages/axe-core-capybara/lib/axe-capybara.rb index eea79426..85b232b7 100644 --- a/packages/axe-core-capybara/lib/axe-capybara.rb +++ b/packages/axe-core-capybara/lib/axe-capybara.rb @@ -25,6 +25,6 @@ def self.configure(browser = :firefox) private def self.get_driver(browserSymbol) - Capybara::Selenium::Driver.new(browserSymbol) + Capybara::Selenium::Driver.new nil, :browser => browserSymbol end end diff --git a/packages/axe-core-capybara/spec/axe-capybara_spec.rb b/packages/axe-core-capybara/spec/axe-capybara_spec.rb index f01371ff..5ce16152 100644 --- a/packages/axe-core-capybara/spec/axe-capybara_spec.rb +++ b/packages/axe-core-capybara/spec/axe-capybara_spec.rb @@ -8,7 +8,7 @@ describe "driver" do it "validate yielded configuration" do - driver = AxeCapybara.configure(:firefox) do + driver = AxeCapybara.configure(:chrome) do end expect(driver).not_to be_nil @@ -27,6 +27,12 @@ }.to yield_with_args(actual) end + # Default is firefox, so we can just check that we can override the default + it "sets browser" do + is_chrome = @driver.page.execute_script "return !!window.chrome" + expect(is_chrome).to be true + end + it "should yield configuration with specified jslib path" do different_axe_path = "different-axe-path/axe.js" From f863b85d6f1fd32aa236cfb4d42acddad203feb9 Mon Sep 17 00:00:00 2001 From: michael-siek Date: Thu, 20 Apr 2023 08:45:39 -0400 Subject: [PATCH 2/4] fix test --- packages/axe-core-capybara/spec/axe-capybara_spec.rb | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/axe-core-capybara/spec/axe-capybara_spec.rb b/packages/axe-core-capybara/spec/axe-capybara_spec.rb index 5ce16152..5f1cb805 100644 --- a/packages/axe-core-capybara/spec/axe-capybara_spec.rb +++ b/packages/axe-core-capybara/spec/axe-capybara_spec.rb @@ -29,7 +29,7 @@ # Default is firefox, so we can just check that we can override the default it "sets browser" do - is_chrome = @driver.page.execute_script "return !!window.chrome" + is_chrome = driver.page.execute_script "return !!window.chrome" expect(is_chrome).to be true end From e1d8d0617b570cf1443b65ece6a49f89c835cd87 Mon Sep 17 00:00:00 2001 From: michael-siek Date: Thu, 20 Apr 2023 08:48:39 -0400 Subject: [PATCH 3/4] set browser --- packages/axe-core-capybara/spec/axe-capybara_spec.rb | 2 ++ 1 file changed, 2 insertions(+) diff --git a/packages/axe-core-capybara/spec/axe-capybara_spec.rb b/packages/axe-core-capybara/spec/axe-capybara_spec.rb index 5f1cb805..0e0386c1 100644 --- a/packages/axe-core-capybara/spec/axe-capybara_spec.rb +++ b/packages/axe-core-capybara/spec/axe-capybara_spec.rb @@ -29,6 +29,8 @@ # Default is firefox, so we can just check that we can override the default it "sets browser" do + driver = AxeCapybara.configure(:chrome) do + end is_chrome = driver.page.execute_script "return !!window.chrome" expect(is_chrome).to be true end From f9f72870b33b087957b9d86525cb1ceee38004b1 Mon Sep 17 00:00:00 2001 From: michael-siek Date: Thu, 20 Apr 2023 08:51:34 -0400 Subject: [PATCH 4/4] revert prior test --- packages/axe-core-capybara/spec/axe-capybara_spec.rb | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/axe-core-capybara/spec/axe-capybara_spec.rb b/packages/axe-core-capybara/spec/axe-capybara_spec.rb index 0e0386c1..388308d4 100644 --- a/packages/axe-core-capybara/spec/axe-capybara_spec.rb +++ b/packages/axe-core-capybara/spec/axe-capybara_spec.rb @@ -8,7 +8,7 @@ describe "driver" do it "validate yielded configuration" do - driver = AxeCapybara.configure(:chrome) do + driver = AxeCapybara.configure(:firefox) do end expect(driver).not_to be_nil