-
Notifications
You must be signed in to change notification settings - Fork 68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
react: Support React v18 #500
Comments
Need this too please, any update on when to expect it? Or any workaround until ready? Thanks! |
Below works for me in React 18. I guess the initialization readme needs to be updated for react 18 with below example
|
@saileshkotha doesn't work for me. Not sure why it does for you but I'm pretty sure this is not the fix. |
Any update on adding this support? |
It works for me if I import
This is my
|
@damian08k it works on the initial render, but not on subsequent updates. |
@mithodin Yes, you're right. I didn't notice that. Is there any chance to update |
@damian08k We will be working on this soon to be able to support all React 18+ projects |
I'm also interested by a workaround, if any of you have a sample repo :D ... currently using Next 13 but I guess it's adaptable once working with React 18 Thank you, |
Also interested in this, we're waiting on implementing axe on this change |
@michael-siek Is there any update on this work? |
Thank you for your continued patience. We've looked into supporting React 18 but at this time it doesn't look like we will be able to. Between issues with React 18 and the deprecation of |
Bumping this, as (1) I'm not looking for a 1:1 solution to restore the old behavior, nor do I have any to propose. I'm wondering instead how the Axe team recommends we implement Axe in a modern React project. To be clear: I am very okay with tradeoffs like "deduplication gets worse" or "Axe always scans the whole page vs. just the changed tree". Mostly looking for a recommended path forward, as it's been almost 18 months since this issue was opened & 9 months since anyone was assigned. |
Can we get the readme updated to indicate this tool is incompatible with React 18 until support is added? |
Hello Axe-core team. Is there any update related with React 18? We need to update to React 18 and we are using Axe-core cli. iIs there a solution that we will be able to continue using it? |
Hi @anagritsay and folks following this comment thread. I'm a Product Manager at Deque and I wanted to make sure we we're communicating clearly on this issue. Following on from @straker's earlier comment on June 14th, 2023, we have not been able to solve this problem. Furthermore, we have no plans to support React 18 and above. I will update the project's README to further communicate our plans. What are the alternatives? Deque will be offering other solutions for developers writing automated tests in the JavaScript and Node ecosystems. During and immediately following axe-con (Feb. 20-22), there will be announcements about our recommended approach. I'll communicate alternatives within the project's README after product announcements have been made. |
Thanks for the update @ballendq. Excited to learn what you recommend! I wonder if it has something to do with |
Thank you for the information @ballendq, looking forward for the update |
Hello |
@AtuHQ, It looks like you can register for the conference (even though it's already past) to get access to the session recordings. I'm trying to find the session with any relevant information now. |
Quick update from Deque - we'll have a product offering coming in late March/early April. The first release will focus on JavaScript/TypeScript testing frameworks. We're still working on the details of this release so there will be more to come when the "official" release is done. Once complete, I can point folks to a blog post etc. The new product will have a free plan and I'll add more commentary to this thread to describe how this might be used in open source. The new release will also have paid plans so that it's suitable for company use. Again, more details coming soon. |
@ballendq Thanks looking forward to the update here! |
@ballendq any update? We're almost out of April. |
React 19 beta was just released, the question is it this will be fixed before it becomes obsolete? |
Yes, early next week. Very end of April. |
|
Folks - we released a new product called axe Developer Hub. This product has numerous JavaScript/TypeScript test framework integrations and is Deque's recommended path forward for users of this library who wish to use more modern versions of React. The product has a free plan where each licensed user gets 1 API key. This is a good option for open-source projects or solo developers looking for high-quality accessibility feedback. Sign up for the free plan. For more information, read the recent blog post: Introducing axe Developer Hub, now available as part of axe DevTools for Web |
Verified with the latest prod version of axe-core/react (4.9.1) Its identifying the issue on react-components properly But its giving Warning message
@straker , is this expected warning on using axe-core/react package. Environment:
|
Product: react
Expectation: React v18 support and docs
Actual: n/a
Motivation: Upgrading an app to use React 18 and want to continue using
@axe-core/react
The text was updated successfully, but these errors were encountered: