diff --git a/lib/checks/shared/non-empty-alt.js b/lib/checks/shared/non-empty-alt.js index 00aeb03628..235188f6fe 100644 --- a/lib/checks/shared/non-empty-alt.js +++ b/lib/checks/shared/non-empty-alt.js @@ -1,2 +1,2 @@ -var label = node.getAttribute('alt'); +const label = virtualNode.attr('alt'); return !!(label ? axe.commons.text.sanitize(label).trim() : ''); diff --git a/test/checks/shared/non-empty-alt.js b/test/checks/shared/non-empty-alt.js index 4db7845616..598b324083 100644 --- a/test/checks/shared/non-empty-alt.js +++ b/test/checks/shared/non-empty-alt.js @@ -2,39 +2,29 @@ describe('non-empty-alt', function() { 'use strict'; var fixture = document.getElementById('fixture'); + var checkSetup = axe.testUtils.checkSetup; afterEach(function() { fixture.innerHTML = ''; }); it('should return true if an alt is present', function() { - var node = document.createElement('img'); - node.setAttribute('alt', 'woohoo'); - fixture.appendChild(node); - - assert.isTrue(checks['non-empty-alt'].evaluate(node)); + var params = checkSetup('woohoo'); + assert.isTrue(checks['non-empty-alt'].evaluate.apply(null, params)); }); it('should return false if an alt is not present', function() { - var node = document.createElement('img'); - fixture.appendChild(node); - - assert.isFalse(checks['non-empty-alt'].evaluate(node)); + var params = checkSetup(''); + assert.isFalse(checks['non-empty-alt'].evaluate.apply(null, params)); }); it('should return false if an alt is present, but empty', function() { - var node = document.createElement('img'); - node.setAttribute('alt', ' '); - fixture.appendChild(node); - - assert.isFalse(checks['non-empty-alt'].evaluate(node)); + var params = checkSetup(' '); + assert.isFalse(checks['non-empty-alt'].evaluate.apply(null, params)); }); it('should collapse whitespace', function() { - var node = document.createElement('div'); - node.setAttribute('alt', ' \t \n \r \t \t\r\n '); - fixture.appendChild(node); - - assert.isFalse(checks['non-empty-alt'].evaluate(node)); + var params = checkSetup(' \t \n \r \t  \t\r\n '); + assert.isFalse(checks['non-empty-alt'].evaluate.apply(null, params)); }); });