Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

has-visible-text check not working as expected #1611

Closed
WilcoFiers opened this issue Jun 5, 2019 · 4 comments
Closed

has-visible-text check not working as expected #1611

WilcoFiers opened this issue Jun 5, 2019 · 4 comments
Labels
breaking change commons Issues in the common code (lib/commons) feat New feature or enhancement

Comments

@WilcoFiers
Copy link
Contributor

The way has-visible-text is set up suggests it looks at visible text content. This isn't true though. Instead, it looks at the accessible name. Instead of calling text.accessibleText this needs to run text.subtreeText. We'll have to look carefully about what the impact of that change is though.
@WilcoFiers WilcoFiers added fix Bug fixes commons Issues in the common code (lib/commons) labels Jun 5, 2019
@WilcoFiers WilcoFiers mentioned this issue Jun 7, 2019
Closed
@dylanb
Copy link
Contributor

dylanb commented Jun 16, 2019

This seems to me to be a bug, so it just needs to be fixed

@WilcoFiers WilcoFiers added feat New feature or enhancement and removed fix Bug fixes labels Jul 1, 2019
@straker
Copy link
Contributor

straker commented Jan 15, 2020

Rename to has-accessible-text.

@straker straker added this to the Axe-core 4.0 milestone Jan 15, 2020
@WilcoFiers WilcoFiers modified the milestones: Axe-core 4.0, axe-core 4.1 Apr 28, 2020
@straker
Copy link
Contributor

straker commented Jul 29, 2020

Should be part of #1006

@WilcoFiers WilcoFiers modified the milestones: axe-core 4.1, Axe-core 5.0 Aug 21, 2020
@straker
Copy link
Contributor

straker commented Sep 4, 2020

Closed via #2234

@straker straker closed this as completed Sep 4, 2020
@WilcoFiers WilcoFiers removed this from the Axe-core 5.0 milestone Nov 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
breaking change commons Issues in the common code (lib/commons) feat New feature or enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@dylanb @WilcoFiers @straker