fix(frame-tested): run without respondable #2942
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WilcoFiers
previously requested changes
May 20, 2021
WilcoFiers
previously requested changes
Jun 2, 2021
| function frameTestedAfter(results) { | ||
| const iframes = {}; | ||
|
|
||
| return results.filter(result => { |
There was a problem hiding this comment.
Well I'll be damned! I did not know you could do a filter in after.
WilcoFiers
previously requested changes
Jun 11, 2021
WilcoFiers
approved these changes
Jun 16, 2021
WilcoFiers
pushed a commit
that referenced
this pull request
Jun 17, 2021
* fix(frame-tested): run without respondable * revert playground and files * add after tests * work with shadow dom * fixes * show undefined for all tests
clottman
pushed a commit
that referenced
this pull request
Jun 17, 2021
* fix(frame-tested): run without respondable * revert playground and files * add after tests * work with shadow dom * fixes * show undefined for all tests
straker
added a commit
that referenced
this pull request
Jun 22, 2021
* fix(frame-tested): run without respondable * revert playground and files * add after tests * work with shadow dom * fixes * show undefined for all tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Be able to run the
frame-testedrule without using respondable.Closes issue: #2939