chore(marketing): Stop capitalizing the "x" in "axe" #1495
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch replaces all instances of "aXe" with "axe". The marketing team has suggested we stop capitalizing the "x" in "axe" for various reasons. It's likely that I've missed something, as this patch was generated by running a find/replace across the codebase rather than making updates individually.
4 tasks
|
Do we still lowercase axe, or do we capitalize it as a proper name (Axe)? |
|
@straker please refer to the The TLDR is "Axe" when starting a sentence and "axe" in all other cases. |
straker
previously approved these changes
Apr 11, 2019
Gruntfile.js
Outdated
| @@ -264,7 +264,7 @@ module.exports = function(grunt) { | |||
| fixture: 'test/runner.tmpl', | |||
| testCwd: 'test/core', | |||
| data: { | |||
| title: 'aXe Core Tests' | |||
| title: 'axe Core Tests' | |||
There was a problem hiding this comment.
Nitpick: Should we capitalize here (and all other places in the file where it starts the title?
There was a problem hiding this comment.
Yep, makes sense to me!
| @@ -33,13 +33,13 @@ Add your project/integration to this file and submit a pull request. | |||
| 1. [Protractor-axe-report Plugin](https://github.com/E1Edatatracker/protractor-axe-report-plugin) | |||
| 1. [Cypress-axe](https://github.com/avanslaars/cypress-axe) | |||
| 1. [Jest-axe](https://github.com/nickcolley/jest-axe) | |||
| 1. [aXe audit runner for CrawlKit](https://github.com/crawlkit/runner-axe) | |||
| 1. [Selenium IDE aXe Extension](https://github.com/bkardell/selenium-ide-axe) | |||
| 1. [axe audit runner for CrawlKit](https://github.com/crawlkit/runner-axe) | |||
There was a problem hiding this comment.
Capitalize? or not since it's the name of someone elses project?
There was a problem hiding this comment.
I didn't capitalize here since neither "audit" nor "runner" were capitalized, but I'm fine with whatever. The purpose of this PR is just to remove the capitalized X. 🤷♀️
Thanks Steven
WilcoFiers
approved these changes
Apr 12, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch replaces all instances of "aXe" with "axe". The marketing overlords have suggested we stop capitalizing the "x" in "axe" for various reasons.
It's likely that I've missed something, as this patch was generated by running a find/replace across the codebase rather than making updates individually.
Reviewer checks
Required fields, to be filled out by PR reviewer(s)