New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(l10n): French localization #933

Merged
merged 39 commits into from Jun 21, 2018

Conversation

Projects
None yet
7 participants
@ffoodd
Contributor

ffoodd commented May 31, 2018

Hi there!

Since I'm using aXe on a daily basis — thanks for this amazing tool! —, I wanted to contribute by translating it in French.
I did my best to follow your contribution guidelines, hoping I passed!

Credits to a few friends who helped me:

ffoodd and others added some commits Apr 29, 2018

@ffoodd ffoodd changed the title from French localization to feat(l10n): French localization May 31, 2018

@WilcoFiers

This comment has been minimized.

Contributor

WilcoFiers commented May 31, 2018

Thank you very much!! That is fantastic!

@dboudreau

This comment has been minimized.

dboudreau commented May 31, 2018

Merci beaucoup pour la contribution, c'est génial! :)

Adding this to my list of things to follow up on, but at first glance, looks really good.

@ffoodd

This comment has been minimized.

Contributor

ffoodd commented Jun 1, 2018

You're welcome!

FWIW, I did my best to use the RGAA glossary, but it's not that easy :) I asked a few people as reviewers, please let them a few days for proofreading ;)

@PhilippeVay PhilippeVay referenced this pull request Jun 1, 2018

Merged

Typos in FR translation #4

6 of 7 tasks complete

ffoodd and others added some commits Jun 1, 2018

@dylanb

This comment has been minimized.

Contributor

dylanb commented Jun 5, 2018

@audrasjb could you please sign the contributor license agreement - we cannot merge any of the changes until this is signed by all contributors

@audrasjb

This comment has been minimized.

audrasjb commented Jun 5, 2018

Hi @dylanb

I just signed the CLA. Let me know if something went wrong.
Cheers,
Jb

@dylanb

This comment has been minimized.

Contributor

dylanb commented Jun 13, 2018

@ffoodd and @dboudreau - is this PR ready for merging?

@ffoodd

This comment has been minimized.

Contributor

ffoodd commented Jun 13, 2018

I think so, I don't get any issue nor PR since a few days 😊

@WilcoFiers WilcoFiers merged commit c79a0b7 into dequelabs:develop Jun 21, 2018

3 checks passed

ci/circleci Your tests passed on CircleCI!
Details
license/cla All CLA requirements met.
security/snyk No dependency changes
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment