New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display link to attached PDF document, not a link to the conversation #114

Closed
Smile4ever opened this Issue Aug 19, 2015 · 4 comments

Comments

Projects
None yet
4 participants
@dequis

This comment has been minimized.

Show comment
Hide comment
@dequis

dequis Aug 19, 2015

Owner

That's by design, unfortunately.

The plugin only shows direct links when there's a reasonable way to get them through the protocol, and in the case of attachments, we never get a direct link or even most of the components required to assemble the URL

This is what we get:

{
    "deltas": [
        {
            "deltaNewMessage": {
                "attachments": [
                    {
                        "fbid": 10207176710279837,
                        "fileSize": 4,
                        "filename": "virus.exe.pdf",
                        "id": "10207176710279837",
                        "mimeType": "application/pdf"
                    }
                ],
                "messageMetadata": {
                    "actorFbId": 134**460,
                    "messageId": "mid.1440003136087:0ca427ee25238b4993",
                    "offlineThreadingId": 6039810909602954791,
                    "tags": [
                        "source:chat:web"
                    ],
                    "threadKey": {
                        "otherUserFbId": 134**460
                    },
                    "timestamp": 1440003136452
                }
            }
        }
    ],
    "firstDeltaSeqId": 1094,
    "lastIssuedSeqId": 1094
}

And this is a corresponding link, copied from webchat:

https://cdn.fbsbx.com/hphotos-xpt1/v/t59.2708-21/11408826_804538156319884_2072831910_n.pdf/virus.exe.pdf?oh=7ba31f9bd6c3027959a8e877f9749921&oe=55D66A4D&dl=1

Note how we don't get any parts of that link in the above information.

In these cases, the best way we have to show that link is to point the user at the conversation URL, so they can grab it from there. Videos work the same way.

So I'm afraid i'll have to close this as wontfix, unless @jgeboski disagrees with me and thinks this is somehow possible. Sorry!

Owner

dequis commented Aug 19, 2015

That's by design, unfortunately.

The plugin only shows direct links when there's a reasonable way to get them through the protocol, and in the case of attachments, we never get a direct link or even most of the components required to assemble the URL

This is what we get:

{
    "deltas": [
        {
            "deltaNewMessage": {
                "attachments": [
                    {
                        "fbid": 10207176710279837,
                        "fileSize": 4,
                        "filename": "virus.exe.pdf",
                        "id": "10207176710279837",
                        "mimeType": "application/pdf"
                    }
                ],
                "messageMetadata": {
                    "actorFbId": 134**460,
                    "messageId": "mid.1440003136087:0ca427ee25238b4993",
                    "offlineThreadingId": 6039810909602954791,
                    "tags": [
                        "source:chat:web"
                    ],
                    "threadKey": {
                        "otherUserFbId": 134**460
                    },
                    "timestamp": 1440003136452
                }
            }
        }
    ],
    "firstDeltaSeqId": 1094,
    "lastIssuedSeqId": 1094
}

And this is a corresponding link, copied from webchat:

https://cdn.fbsbx.com/hphotos-xpt1/v/t59.2708-21/11408826_804538156319884_2072831910_n.pdf/virus.exe.pdf?oh=7ba31f9bd6c3027959a8e877f9749921&oe=55D66A4D&dl=1

Note how we don't get any parts of that link in the above information.

In these cases, the best way we have to show that link is to point the user at the conversation URL, so they can grab it from there. Videos work the same way.

So I'm afraid i'll have to close this as wontfix, unless @jgeboski disagrees with me and thinks this is somehow possible. Sorry!

@dequis dequis closed this Aug 19, 2015

@dequis dequis added the wontfix label Aug 19, 2015

@marsjaninzmarsa

This comment has been minimized.

Show comment
Hide comment
@marsjaninzmarsa

marsjaninzmarsa Aug 19, 2015

5 minutes of googling, but I don't know if it's still working.

http://stackoverflow.com/questions/9192430/view-attachments-in-threads

5 minutes of googling, but I don't know if it's still working.

http://stackoverflow.com/questions/9192430/view-attachments-in-threads

@jgeboski jgeboski added enhancement and removed wontfix labels Aug 21, 2015

@jgeboski jgeboski reopened this Aug 21, 2015

@jgeboski

This comment has been minimized.

Show comment
Hide comment
@jgeboski

jgeboski Aug 21, 2015

Collaborator

This has been implemented as of 2d832af0f400, and will appear in the next release.

@marsjaninzmarsa Thanks for the link! This is still active and used.

Collaborator

jgeboski commented Aug 21, 2015

This has been implemented as of 2d832af0f400, and will appear in the next release.

@marsjaninzmarsa Thanks for the link! This is still active and used.

@jgeboski jgeboski closed this Aug 21, 2015

@jgeboski jgeboski added the resolved label Aug 21, 2015

@marsjaninzmarsa

This comment has been minimized.

Show comment
Hide comment

😸

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment