New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Messages received repeated/duplicated periodically until disconnect/reconnect #155

Closed
PorcelainMouse opened this Issue Oct 14, 2015 · 22 comments

Comments

Projects
None yet
9 participants
@PorcelainMouse

Recently, when at least one of my FB friends sends me a txt mesg, purple-facebook will periodically repeat/replay/duplicate the exact messages. They come in like new messages, in order, but I can see from the buffer that they are repeats.

It may not be everyone, though. It has been happening always for one particular friend with whom I most often communicate via FB since this symptom began. I only goes away when close and reopen the FB connection, manually. But, I don't think it happened with someone I happen to chat with the other day, so it's not everyone.

Anyone else see this? Perhaps it is some interaction with the sender's FB client?

@jgeboski

This comment has been minimized.

Show comment
Hide comment
@jgeboski

jgeboski Oct 14, 2015

Collaborator

So, you can confirm the duplicate message(s) are sent over the MQTT stream?

Collaborator

jgeboski commented Oct 14, 2015

So, you can confirm the duplicate message(s) are sent over the MQTT stream?

@PorcelainMouse

This comment has been minimized.

Show comment
Hide comment
@PorcelainMouse

PorcelainMouse Oct 14, 2015

Hmm, I'm not sure. I'm willing to test, but I don't know enough to design a test for that. Do you have a test in mind? What else would it be? I can confirm they come from my FB contact, not the same person on another network, for example. Does FB use anything other than MQTT? I only have the one FB account and this is my only FB-chat plugin for purple.

UPDATE: oops, didn't mean to close.

Hmm, I'm not sure. I'm willing to test, but I don't know enough to design a test for that. Do you have a test in mind? What else would it be? I can confirm they come from my FB contact, not the same person on another network, for example. Does FB use anything other than MQTT? I only have the one FB account and this is my only FB-chat plugin for purple.

UPDATE: oops, didn't mean to close.

@jgeboski

This comment has been minimized.

Show comment
Hide comment
@jgeboski

jgeboski Oct 17, 2015

Collaborator

The easiest thing to do would be to run the plugin with debugging enabled. Then, grep the debug output for the duplicated message, and see how many times it shows up in the results. If it is more than once, then Facebook is sending more than one message.

Collaborator

jgeboski commented Oct 17, 2015

The easiest thing to do would be to run the plugin with debugging enabled. Then, grep the debug output for the duplicated message, and see how many times it shows up in the results. If it is more than once, then Facebook is sending more than one message.

@jgeboski

This comment has been minimized.

Show comment
Hide comment
@jgeboski

jgeboski Oct 26, 2015

Collaborator

I can confirm this is happening to me as well.

Collaborator

jgeboski commented Oct 26, 2015

I can confirm this is happening to me as well.

@Smile4ever

This comment has been minimized.

Show comment
Hide comment
@Smile4ever

Smile4ever Oct 31, 2015

I sometimes get the message up to 4 times, with more or less the same timestamp (max a few seconds difference).

I sometimes get the message up to 4 times, with more or less the same timestamp (max a few seconds difference).

@jgeboski

This comment has been minimized.

Show comment
Hide comment
@jgeboski

jgeboski Oct 31, 2015

Collaborator

@dequis provided me a log, and the message identifiers and time stamps are indeed the same. I still would like to poke at it more before patching based on time stamp or message identifiers to ensure consistency.

Collaborator

jgeboski commented Oct 31, 2015

@dequis provided me a log, and the message identifiers and time stamps are indeed the same. I still would like to poke at it more before patching based on time stamp or message identifiers to ensure consistency.

@Smile4ever

This comment has been minimized.

Show comment
Hide comment
@Smile4ever

Smile4ever Oct 31, 2015

If you fix it by comparing the timestamps, make sure you cover this case as well:
18:41:33,500 the same message
18:41:33,700 the same message
18:41:33,900 the same message
18:41:34,200 the same message

If you fix it by comparing the timestamps, make sure you cover this case as well:
18:41:33,500 the same message
18:41:33,700 the same message
18:41:33,900 the same message
18:41:34,200 the same message

@jgeboski

This comment has been minimized.

Show comment
Hide comment
@jgeboski

jgeboski Oct 31, 2015

Collaborator

Yes. It would need to be a mix of the message identifiers and time stamps.

Collaborator

jgeboski commented Oct 31, 2015

Yes. It would need to be a mix of the message identifiers and time stamps.

@Smile4ever

This comment has been minimized.

Show comment
Hide comment
@Smile4ever

Smile4ever Nov 1, 2015

I found another case which has the same outcome:
(11:03:06) same message
Failed to read fixed header -> click Reconnect
(11:03:15) same message

I found another case which has the same outcome:
(11:03:06) same message
Failed to read fixed header -> click Reconnect
(11:03:15) same message

@Smile4ever

This comment has been minimized.

Show comment
Hide comment
@Smile4ever

Smile4ever Nov 1, 2015

This bug applies for images as well.

This bug applies for images as well.

@aeridus

This comment has been minimized.

Show comment
Hide comment
@aeridus

aeridus Dec 6, 2015

I also have this problem. Aside from this bug, the plugin has been flawless, so I really hope this gets fixed soon.

This works in reverse, too. A friend of mine saw a whole bunch of repeats of one of my messages.

aeridus commented Dec 6, 2015

I also have this problem. Aside from this bug, the plugin has been flawless, so I really hope this gets fixed soon.

This works in reverse, too. A friend of mine saw a whole bunch of repeats of one of my messages.

@deekej

This comment has been minimized.

Show comment
Hide comment
@deekej

deekej Dec 7, 2015

I have the similar/same issue, both on Linux & Windows platform.
For me, when I receive a single message, it is duplicated many times instantly.

I can post a screenshot, if necessary, after it happens again.

deekej commented Dec 7, 2015

I have the similar/same issue, both on Linux & Windows platform.
For me, when I receive a single message, it is duplicated many times instantly.

I can post a screenshot, if necessary, after it happens again.

@dequis

This comment has been minimized.

Show comment
Hide comment
@dequis

dequis Dec 28, 2015

Owner

Posting here for reference:

orca 39.0.0.23.150 (2015-09-10) is affected http://dump.dequis.org/p2d_8.txt (but does client-side deduplication)

orca 52.0.0.19.66 (2015-12-16) isn't http://dump.dequis.org/t7SiC.txt (at least over 200 messages)

Owner

dequis commented Dec 28, 2015

Posting here for reference:

orca 39.0.0.23.150 (2015-09-10) is affected http://dump.dequis.org/p2d_8.txt (but does client-side deduplication)

orca 52.0.0.19.66 (2015-12-16) isn't http://dump.dequis.org/t7SiC.txt (at least over 200 messages)

@jgeboski

This comment has been minimized.

Show comment
Hide comment
@jgeboski

jgeboski Jan 7, 2016

Collaborator

This has most been resolved as of ad2ee74, which is in the latest release.

Collaborator

jgeboski commented Jan 7, 2016

This has most been resolved as of ad2ee74, which is in the latest release.

@jgeboski jgeboski closed this Jan 7, 2016

@jgeboski jgeboski added the resolved label Jan 7, 2016

@Smile4ever

This comment has been minimized.

Show comment
Hide comment
@Smile4ever

Smile4ever Jan 9, 2016

Great! Thank you!

Great! Thank you!

@PaulDeStefano

This comment has been minimized.

Show comment
Hide comment
@PaulDeStefano

PaulDeStefano Jan 26, 2016

Yes, me too. Best I can tell, this is fixed. Thanks!

Yes, me too. Best I can tell, this is fixed. Thanks!

@PaulDeStefano

This comment has been minimized.

Show comment
Hide comment
@PaulDeStefano

PaulDeStefano Jan 31, 2016

Actually, it happened to me again. 25a255f32eee.

Actually, it happened to me again. 25a255f32eee.

@jgeboski

This comment has been minimized.

Show comment
Hide comment
@jgeboski

jgeboski Jan 31, 2016

Collaborator

Please see the commit message. The fix is not bulletproof.

Collaborator

jgeboski commented Jan 31, 2016

Please see the commit message. The fix is not bulletproof.

@PaulDeStefano

This comment has been minimized.

Show comment
Hide comment
@PaulDeStefano

PaulDeStefano Jan 31, 2016

Got it, thanks!

Got it, thanks!

@greatquux

This comment has been minimized.

Show comment
Hide comment
@greatquux

greatquux Feb 1, 2016

I've only noticed it happening when a message has come in, and I have not switched to the pidgin window ro read it (and therefore mark it as read, or mark it as read some other way). so it's mostly fixed for now.

I've only noticed it happening when a message has come in, and I have not switched to the pidgin window ro read it (and therefore mark it as read, or mark it as read some other way). so it's mostly fixed for now.

@jgeboski jgeboski referenced this issue Mar 11, 2016

Open

Protocol Update #227

1 of 6 tasks complete
@masterxq

This comment has been minimized.

Show comment
Hide comment
@masterxq

masterxq Apr 29, 2016

Hello, this bug still apears for me.
I'm using purple-facebook from Debian repository.
Version:
201604092a24dff66ee77378d82~110
I'm not absolutly sure, but it seens that i repeatly get the message every time i reconnect.

I'm using purple-facebook with spectrum2 for ejabberd with xabber as client.

Hello, this bug still apears for me.
I'm using purple-facebook from Debian repository.
Version:
201604092a24dff66ee77378d82~110
I'm not absolutly sure, but it seens that i repeatly get the message every time i reconnect.

I'm using purple-facebook with spectrum2 for ejabberd with xabber as client.

@dequis

This comment has been minimized.

Show comment
Hide comment
@dequis

dequis Apr 29, 2016

Owner

@masterxq

Quoting from above:

Please see the commit message. The fix is not bulletproof.

However, you seem to be describing something unrelated to this issue.

It sounds like you've disabled mark as read (or it doesn't work with spectrum) and that you have show unread messages enabled. Disabling that one should do it.

In the future (or if you have any further issues) please open a new issue. I'm locking this one.

Owner

dequis commented Apr 29, 2016

@masterxq

Quoting from above:

Please see the commit message. The fix is not bulletproof.

However, you seem to be describing something unrelated to this issue.

It sounds like you've disabled mark as read (or it doesn't work with spectrum) and that you have show unread messages enabled. Disabling that one should do it.

In the future (or if you have any further issues) please open a new issue. I'm locking this one.

Repository owner locked and limited conversation to collaborators Apr 29, 2016

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.