New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Attempt to reconnect silently #186

Closed
jgeboski opened this Issue Dec 27, 2015 · 4 comments

Comments

Projects
None yet
3 participants
@jgeboski
Collaborator

jgeboski commented Dec 27, 2015

The plugin should attempt to reconnect silently after being disconnect by Facebook. Typically, when Facebook disconnects the plugin, the plugin is able to reconnect immediately after. I can only assume this is some sort of load balancing, after all this is a mobile platform. It has also been reported that logging out on the Facebook website causes the MQTT stream to be closed as well (#171). I can only assume there are other actions which trigger the MQTT stream to die as well. Pidgin will automatically reconnect the plugin after such a disconnection as of 50bb40c, but the user sees an error. While these issues are trivial and low priority, the plugin could be more streamlined by providing a reconnection mechanism in the background.

We are able to keep track of the previous sequence identifier, which will allow us to pick up where we left off with the MQTT stream. In addition, we can queue the outbound MQTT messages, and ensure they are sent once the connection is reestablished. This should allow for such a reconnection mechanism to be easily implemented.

@redhead

This comment has been minimized.

Show comment
Hide comment
@redhead

redhead Dec 31, 2015

Does this relate to a situation, where I start up my computer from sleep mode, so it lost connection to facebook? It does not reconnect by itself, but I have to manually disable the account and enable it again for it to work. It's pretty irritating

redhead commented Dec 31, 2015

Does this relate to a situation, where I start up my computer from sleep mode, so it lost connection to facebook? It does not reconnect by itself, but I have to manually disable the account and enable it again for it to work. It's pretty irritating

@jgeboski

This comment has been minimized.

Show comment
Hide comment
@jgeboski

jgeboski Dec 31, 2015

Collaborator

@redhead no. This issue has already been resolved in the latest version, please update.

Collaborator

jgeboski commented Dec 31, 2015

@redhead no. This issue has already been resolved in the latest version, please update.

@rrthomas

This comment has been minimized.

Show comment
Hide comment
@rrthomas

rrthomas Jan 6, 2016

This would be great to have: it's a minor distraction that my Pidgin tray icon keeps cycling through connected and connecting, purely because of the Facebook plugin.

rrthomas commented Jan 6, 2016

This would be great to have: it's a minor distraction that my Pidgin tray icon keeps cycling through connected and connecting, purely because of the Facebook plugin.

@jgeboski

This comment has been minimized.

Show comment
Hide comment
@jgeboski

jgeboski Jan 7, 2016

Collaborator

This has been resolved as of 45f10c2, which is in the latest release.

Collaborator

jgeboski commented Jan 7, 2016

This has been resolved as of 45f10c2, which is in the latest release.

@jgeboski jgeboski closed this Jan 7, 2016

@jgeboski jgeboski added the resolved label Jan 7, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment