New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Duplicate messages using latest purple-facebook #199

Closed
Smile4ever opened this Issue Jan 16, 2016 · 1 comment

Comments

Projects
None yet
2 participants
@Smile4ever

If you would check the last ~10 messages instead of only the last message to deduplicate, this would be solved too:
bug-purple-facebook-priv

@jgeboski

This comment has been minimized.

Show comment
Hide comment
@jgeboski

jgeboski Jan 16, 2016

Collaborator

This still would not provide a bullet proof solution. Messages can be duplicated after differing periods of time as well, rather than just sequentially. So, rather than checking the last n messages, it really needs to check the messages over a time span. Even still, it would be hard to get this timing right as well.

The proper solution, as noted in ad2ee74, is to use the latest revision of the Facebook Messenger Protocol. The only reason ad2ee74 exists is because it is very simple, and it addresses the most common duplication case. I really have no interest in making things overly complex, especially when it will never provide a bullet proof solution. Moreover, it is not even a proper solution to the issue at hand.

Collaborator

jgeboski commented Jan 16, 2016

This still would not provide a bullet proof solution. Messages can be duplicated after differing periods of time as well, rather than just sequentially. So, rather than checking the last n messages, it really needs to check the messages over a time span. Even still, it would be hard to get this timing right as well.

The proper solution, as noted in ad2ee74, is to use the latest revision of the Facebook Messenger Protocol. The only reason ad2ee74 exists is because it is very simple, and it addresses the most common duplication case. I really have no interest in making things overly complex, especially when it will never provide a bullet proof solution. Moreover, it is not even a proper solution to the issue at hand.

@jgeboski jgeboski closed this Jan 16, 2016

@jgeboski jgeboski added the wontfix label Jan 16, 2016

@jgeboski jgeboski referenced this issue Mar 11, 2016

Open

Protocol Update #227

1 of 6 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment