New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problem with exported lights #264

Closed
kucoman opened this Issue Jun 21, 2017 · 4 comments

Comments

Projects
None yet
3 participants
@kucoman

kucoman commented Jun 21, 2017

I just tried to export the Rotate MD-80 with the last version of the exporter. Only one issue came up until now. The exported exterior lights are different than with previous versions of the exporter.

Attached are a test blender file, and two exported objs, with the different exporters. I have used version 3.20 (this is working ok) and the last version 3.3.13. (I took it from here
https://github.com/der-On/XPlane2Blender/tree/259-fix-attribute-reset)

In the last version of the exporter, the lights point somewhere unexpected.

Rotate-MD-80-lights-test.zip

The exterior lights you find in the blend file, correspond to the configuration that was found to give better results in the former 3.20, that is, pointing the lights using bones to direct them, and the internal light's parameters to control aperture, color, ...
I am not sure if a better workflow is recommended now with the new versions of the exporter.

Please, let me know if you need me to provide more information.

@bsupnik

This comment has been minimized.

Show comment
Hide comment
@bsupnik

bsupnik Jun 22, 2017

Collaborator

I think the latest commit (b275b8f) on the v3-3 branch should fix this. Please try the latest v3-3 branch and let me know if the bug is fixed or not!

Collaborator

bsupnik commented Jun 22, 2017

I think the latest commit (b275b8f) on the v3-3 branch should fix this. Please try the latest v3-3 branch and let me know if the bug is fixed or not!

@bsupnik bsupnik self-assigned this Jun 22, 2017

@bsupnik bsupnik closed this Jul 21, 2017

@kucoman

This comment has been minimized.

Show comment
Hide comment
@kucoman

kucoman Sep 19, 2017

I have tried this with v3.4.0-beta.4, and the problem with the lights persist in the Rotate MD-80.
Las version of branch v3-3 gives the same result.
Let me know if there is any additional info I can provide.

kucoman commented Sep 19, 2017

I have tried this with v3.4.0-beta.4, and the problem with the lights persist in the Rotate MD-80.
Las version of branch v3-3 gives the same result.
Let me know if there is any additional info I can provide.

@bsupnik bsupnik reopened this Sep 19, 2017

@kucoman

This comment has been minimized.

Show comment
Hide comment
@kucoman

kucoman Sep 19, 2017

In case I was not clear. Location of the lights is ok. It is rotation that is not working as expected. Lights are pointed to the front no matter what the bone's direction is. And, apparently it only happens to the lights attached to non-animated bones, but I have not been able to confirm this point.

kucoman commented Sep 19, 2017

In case I was not clear. Location of the lights is ok. It is rotation that is not working as expected. Lights are pointed to the front no matter what the bone's direction is. And, apparently it only happens to the lights attached to non-animated bones, but I have not been able to confirm this point.

bsupnik pushed a commit that referenced this issue Sep 20, 2017

Ben Supnik
bug fix: possible fix for #264 - baked animation on lights implemented.
We didn’t have any code to handle bake matrices on lights ,and the new
animation code optimizes rotations so now we actually have them.

This should output enough code for the MD-80 to work.
@tngreene

This comment has been minimized.

Show comment
Hide comment
@tngreene

tngreene Nov 15, 2017

Collaborator

Fixed with 9329a8d.

Collaborator

tngreene commented Nov 15, 2017

Fixed with 9329a8d.

@tngreene tngreene closed this Nov 15, 2017

@tngreene tngreene removed the in progress label Aug 25, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment