New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Due to trace Blender DNA, custom lights can still recieve a light overload #317

Closed
tngreene opened this Issue Nov 28, 2017 · 1 comment

Comments

Projects
None yet
1 participant
@tngreene
Copy link
Collaborator

tngreene commented Nov 28, 2017

In xplane_light.py, line 93, this line
self.lightOverload = xplane_lights_txt_parser.get_overload(self.lightName)

is supposed to always return None for custom lights, however if you follow the following steps

  1. Create a light, set it to named or param
  2. Give it a valid light name
  3. Change the light type to Custom
  4. Make the lamp a non-point light

You will get autocorrection.

Temporarily, affected people can run the following snippet to remove the light name from all lights currently set to custom.

import bpy

for lamp in bpy.data.lamps:
    if lamp.xplane.type == "custom":
        print(lamp.name)
        print(lamp.xplane.name)
        
        lamp.xplane.lightName = ""

Actual steps to resolve will be a code fix and adding to known_vs_unknown_named_vs_param.test

@tngreene tngreene added this to the v3.4.0-beta milestone Nov 28, 2017

@tngreene tngreene self-assigned this Nov 28, 2017

@tngreene

This comment has been minimized.

Copy link
Collaborator

tngreene commented Nov 28, 2017

Also related #316

tngreene added a commit that referenced this issue Dec 4, 2017

@tngreene tngreene closed this Dec 4, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment