Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom handling of client-go/rest warnings #178

Closed
Goodwine opened this issue Jun 30, 2021 · 1 comment
Closed

Custom handling of client-go/rest warnings #178

Goodwine opened this issue Jun 30, 2021 · 1 comment

Comments

@Goodwine
Copy link

@Goodwine Goodwine commented Jun 30, 2021

Required by my employer: "Not a Contribution."




Is your feature request related to a problem? Please describe.

When running popeye, client-go/rest may output warnings to stderr such as deprecated resources or throttling.

client-go/rest has a setting to change this behavior or disable such warnings, and it would be nice if Popeye allowed customizing or setting a warning handler.

Describe the solution you'd like

Ideally being able to define my own handler

Describe alternatives you've considered

If defining my own handler is not feasible, it would be cool to at least be able to set a flag that would disable warnings.

Additional context

Not currently allowed to share technical solution or provide code samples, however both possible solutions are mentioned and documented here:
https://kubernetes.io/blog/2020/09/03/warnings/#customize-client-handling

derailed added a commit that referenced this issue Jul 16, 2021
derailed added a commit that referenced this issue Jul 16, 2021
POP-188: fix #188 and #178
@derailed
Copy link
Owner

@derailed derailed commented Jul 16, 2021

@Goodwine Thank you for the heads up! Routing warning to the logger now. Let' see if we're happier on v0.9.6...

@derailed derailed closed this Jul 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants