Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

bugfix: pubSub don't init data if error, creating speculative objcts #19

Closed
wants to merge 2 commits into
from

Conversation

Projects
None yet
2 participants
Member

rma4ok commented May 7, 2012

No description provided.

rma4ok added some commits May 7, 2012

@rma4ok rma4ok Don't init data if error 70948f5
@rma4ok rma4ok Fix for creating speculative obj.
Cuz model doesn't read '_local' namespaces from __proto__
d6339e4
Contributor

nateps commented May 24, 2012

The first commit fixed a bug, but the second commit does not appear necessary. I can't reproduce in the latest version. I fixed the first bug separetly in 9c31b6a

Contributor

nateps commented May 24, 2012

@rma4ok can you try testing again from head and see if you can still reproduce the bug?

Member

rma4ok commented May 24, 2012

Yep. Bug still exist but I can reproduce only with racer db adaptor connected.

Member

rma4ok commented May 24, 2012

I think it's because by custom db adapter. Let me look through more

Member

rma4ok commented May 24, 2012

If you can take a look and say me what I am missing?
https://gist.github.com/cc62d5c99a66315bb78a

Member

rma4ok commented May 24, 2012

I found it!
I dropped EventEmitter prototype. That's why

...
  EventEmitter.call this
...
  __proto__: EventEmitter::
...

Thanks for your cooperation!

Could you please next time pay attention on pull requests faster?
rma4ok opened this pull request 18 days ago

Contributor

nateps commented May 25, 2012

@rma4ok We've been going through quite a lot of craziness over the past few weeks, but we'll do our best. Thanks for your interest, and your help with fixing bugs!

@nateps nateps closed this May 25, 2012

Member

rma4ok commented May 25, 2012

If you have some time. Would you please be so kind to take a look at
https://gist.github.com/cc62d5c99a66315bb78a

EventEmitter didn't help really
I replaced my internal api adapter with just static user data.

To use it in server/index.coffee

derby.use(require '../racer-db')

app.createStore
    listen: server
    db    :
      type: 'Fondu'

I still have that bug

model.set '_IAmGonnaDisappear', 'Pleaseee! Nooooo!!'
console.log model.get()
model.fetch 'path' , ->
  console.log model.get()
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment