Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Manifest allows components with the same name #537

Open
BenElgar opened this issue Dec 1, 2021 · 2 comments
Open

[BUG] Manifest allows components with the same name #537

BenElgar opened this issue Dec 1, 2021 · 2 comments
Labels
bug Something isn't working
Milestone

Comments

@BenElgar
Copy link
Contributor

BenElgar commented Dec 1, 2021

This is a manifest that is apparently valid and is successfully applied:

exo = "0.1"
components {
  container "t0" {
    image = "bash"
    command = "sleep infinity"
  }
  container "t0" {
    image = "alpine"
    command = "sleep infinity"
  }
}

In practice this seems to consistently run the bash container:

❯ dexo apply
Job URL: http://localhost:44643/#/jobs/8kjz638hb3838jwdhspg5ctqsm
applying
✓ ├─ deleting t0
✓ └─ re-creating t0

❯ docker ps
CONTAINER ID   IMAGE          COMMAND                  CREATED          STATUS          PORTS     NAMES
72b76bf1e65f   8856ae160078   "docker-entrypoint.s…"   25 seconds ago   Up 24 seconds             focused_proskuriakova

❯ docker inspect 8856ae160078 | jq '.[0].RepoTags'
[
  "bash:5",
  "bash:latest"
]
@BenElgar BenElgar added bug Something isn't working needs triage Incoming request that needs to be triaged and prioritized labels Dec 1, 2021
@brandonbloom
Copy link
Member

Yeah, we should definitely reject this!

@brandonbloom brandonbloom removed the needs triage Incoming request that needs to be triaged and prioritized label Dec 1, 2021
@brandonbloom
Copy link
Member

This should be resolved in #543 by virtue of Cue's unification logic.

@brandonbloom brandonbloom added this to the Overhaul milestone Feb 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants