Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Horde.Registry.select/2 #110

Merged
merged 1 commit into from May 13, 2019

Conversation

@Shikanime
Copy link
Contributor

commented May 7, 2019

PR Checklist

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

Feature

What is the current behaviour ?

Fixes: #101

What is the new behaviour ?

As for match/4, this is a new function used to match on the keys instead.

Does this PR introduce a breaking change?

No

Additional context

@derekkraan Is there a code convention or a commit naming convention to respect? I would like to contribute more and looking to improve documentation.

@derekkraan derekkraan merged commit a33adac into derekkraan:master May 13, 2019

1 check passed

ci/circleci Your tests passed on CircleCI!
Details
@derekkraan

This comment has been minimized.

Copy link
Owner

commented May 13, 2019

Thanks, this looks great!

@derekkraan derekkraan changed the title Add registry select/4 Add registry select/2 May 15, 2019

@derekkraan derekkraan changed the title Add registry select/2 Add Horde.Registry.select/2 May 15, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.