Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dynamic Supervisor does not ensure uniqueness #196

Merged
merged 3 commits into from Mar 15, 2020

Conversation

derekkraan
Copy link
Owner

@derekkraan derekkraan commented Feb 27, 2020

The main change in this PR is to Horde.DynamicSupervisor.

Previously, it would "take over" a process by assigning it to itself if it found that it was on a dead node and it should be allocated to itself.

Now, it will not take over the process, but duplicate it.

Deduplication will be the sole responsibility of Horde.Registry (on netsplit heal, for example).

derekkraan added 2 commits Feb 4, 2020
This is to prevent Horde.DynamicSupervisor from doing any de-duping. We
cannot allow _both_ Horde.Registry and Horde.DynamicSupervisor to
de-dupe, so we will make this the exclusive domain of Horde.Registry.
@derekkraan derekkraan merged commit ed272b4 into master Mar 15, 2020
1 check failed
@derekkraan derekkraan deleted the dynamic_supervisor_no_id branch Mar 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant