Skip to content
Commits on Jun 13, 2012
  1. @pricem
  2. @pricem

    Move user searching code from new comm panel into controller

    pricem committed
    This is intended to make it easier for other parts of the Web site to use
    the new user searching interfaces defined in UserSearchController.
  3. @pricem

    Fix bug in 'select user checklist'

    pricem committed
    This amends commit 319f63f to submit the checklist form to the
    commpanel_old URL rather than commpanel, because the commpanel view does
    not yet handle checklist input and I saw no need to duplicate the code (at
    least while we keep the old comm panel available).
Commits on Jun 12, 2012
  1. @pricem

    Add directions for editing resource type choices

    pricem committed
    We don't have this capability in any of our views right now, but it is
    possible to do with the Django admin interface, so I edited the template
    where you would expect to find this feature with an explanatory note.  We
    should eventually add this capability to the resource types form where it
    belongs, see #372.
  2. @pricem

    Add 'select from checklist' buttons to comm panel

    pricem committed
    The old comm panel had a button called "I want a subset of this list"
    which took you to a page with a checkbox for each user in the QuerySet you
    had generated.  The redesigned comm panel UI was lacking such an option,
    so I added it.  For the time being it uses the old user search code, but
    I think the UI is acceptable.  In the future we should centralize all of
    the code that is used for user searching.
Commits on Jun 10, 2012
  1. @jmoldow
Commits on May 30, 2012
  1. @pricem
  2. @pricem
  3. @pricem
  4. @pricem
  5. @pricem
  6. @pricem
  7. @pricem
  8. @pricem
  9. @pricem
Commits on May 29, 2012
  1. @pricem
  2. @pricem
  3. @pricem

    Fix server error on some comm panel queries

    pricem committed
    MIT noticed that when asking for a list of teachers for Spark 2012, you
    would get a server error after clicking "Continue to compose e-mail."
    This was caused by a string encoding issue in the PersistentQueryFilter
    model.  The Q object constructed for the query (e.g. "teachers teaching an
    approved class") contained information about the class subjects, including
    their Unicode class descriptions.  When this Q object was pickled, the
    result was an ASCII string containing some Unicode data.  PostgreSQL (or
    any Python string codec) was not happy with this formatting.
    
    The solution is to force the queries to avoid including any fields on
    ClassSubject that can contain non-ASCII data and hence trip up
    PersistentQueryFilter like that.  A more general solution making
    PersistentQueryFilter deal with arbitrary Q objects would be welcome.
  4. @pricem

    Fix a bug in program-specific comm panel queries

    pricem committed
    Some program queries rely on UserBits, and since user types are also
    stored in UserBits we cannot store both of these queries in a single Q
    object (e.g. ESPUser.filter(q1).filter(q2) works, but ESPUser.filter(q1 &
    q2) doesn't).  To compensate, we ignore the user type when performing a
    program-specific query.
  5. @pricem

    Make getBooleanTag more flexible about the exact Tag value

    pricem committed
    The implementation now accepts a numerical '1' and also accepts whitespace
    on either side of "true" or "True".
  6. @pricem
  7. @pricem

    Add getBooleanTag template tag

    pricem committed
    We have a getProgramTag template tag which is helpful.  This adds a
    convenience tag getBooleanTag for the case where you know the Tag value is
    true or false.
  8. @pricem

    Fix incorrect nametag link in main program management page

    pricem committed
    We were linking to 'generatetags' instead of the proper main_call
    'selectidoptions', so you would see an error message "Please select the
    TYPE of Name Tag to Print" instead of getting to configure the nametag
    generator.
  9. @pricem

    Make uploaded files show up as links in custom forms responses table

    pricem committed
    This was done by using a custom formatter in jqGrid.
  10. @pricem

    Make customforms creation tolerant of missing 'required' field

    pricem committed
    We were getting errors on some submissions of /customforms/create because
    the 'required' field of the metadata was missing.  This change makes the
    POST handling code assume that 'required' came from a checkbox (which it
    currently does) and make the field non-required unless the 'required'
    field is present and set to 'checked'.
Commits on May 22, 2012
  1. @pricem

    Fix bug in getBooleanTag

    pricem committed
Commits on May 21, 2012
  1. @gkanwar
  2. @gkanwar
  3. @gkanwar
  4. @gkanwar
  5. @gkanwar
Commits on May 20, 2012
  1. @pricem
  2. @pricem
  3. @pricem

    Make SplitDateWidget year range configurable

    pricem committed
    This is used to narrow the range of possible birthdays in the
    StudentInfoForm.
  4. @pricem
Something went wrong with that request. Please try again.