Document test and cs check better.

.gitignore

@@ -1,5 +1,6 @@
 /vendor/
 /build/
+/tmp/
 composer.lock
 composer.phar
 phpunit.phar

README.md

@@ -31,17 +31,21 @@ There are always some providers changing their URLs/API or some new ones which a
 
 ## Installation
 
-Add the dependency to your `composer.json`:
+Run
+```bash
+php composer.phar require dereuromark/media-embed
+```
+This will get the latest tagged version for you.
 
+Or manually add the dependency to your `composer.json`:
 ```json
 {
     "require": {
         "dereuromark/media-embed": "0.*"
     }
 }
 ```
-
-run:
+and run:
 
 ```bash
 php composer.phar install
@@ -229,5 +233,23 @@ You can see live examples when you get this repo running locally and browse to `
 ## Contribute / TODOs
 See [wiki](https://github.com/dereuromark/MediaEmbed/wiki).
 
+Run tests with
+```
+composer test-setup
+composer test
+```
+
+Run coverage
+```
+composer test-coverage
+```
+and browse to the genrated `tmp/index.php` via browser.
+
+Run CS check/fix with
+```
+composer cs-check
+composer cs-fix
+```
+
 ## Credits
 Inspired by [autoembed](http://autoembed.com/) which already included most of the supported services and laid the foundation of this OOP approach here.

composer.json

@@ -10,15 +10,24 @@
 			"homepage": "http://www.dereuromark.de"
 		}
 	],
-	"autoload": {
-		"psr-0": {
-			"": "src/"
-		}
-	},
 	"require": {
 		"php": ">=5.4"
 	},
 	"require-dev":{
 		"fig-r/psr2r-sniffer": "dev-master"
+	},
+	"autoload": {
+		"psr-0": {
+			"": "src/"
+		}
+	},
+	"scripts": {
+		"post-install-cmd": "App\\Console\\Installer::postInstall",
+		"post-autoload-dump": "Cake\\Composer\\Installer\\PluginInstaller::postAutoloadDump",
+		"test": "phpunit",
+		"test-coverage": "phpunit --log-junit tmp/coverage/unitreport.xml --coverage-html tmp/coverage --coverage-clover tmp/coverage/coverage.xml",
+		"test-setup": "[ ! -f phpunit.phar ] && wget https://phar.phpunit.de/phpunit.phar || true",
+		"cs-check": "phpcs -v -p --standard=vendor/fig-r/psr2r-sniffer/PSR2R/ruleset.xml --ignore=/vendor/,/tmp/,/tests/test_files/ --extensions=php ./",
+		"cs-fix": "phpcbf -v --standard=vendor/fig-r/psr2r-sniffer/PSR2R/ruleset.xml --ignore=/vendor/,/tmp/,/tests/test_files/ --extensions=php ./"
 	}
 }

examples/index.php

@@ -100,7 +100,6 @@
 
 		echo '<div><h3>Embed code:</h3><textarea>' . htmlspecialchars($embed) . '</textarea></div>';
 
-
 		echo '</td><td>';
 		$id = $Object->id();
 		$slug = $Object->slug();

src/MediaEmbed/MediaEmbed.php

@@ -97,19 +97,22 @@ public function parseId($id, $host, $config = []) {
 	 */
 	public function parseUrl($url, $config = []) {
 		foreach ($this->_hosts as $stub) {
-			if ($match = $this->_matchUrl($url, (array)$stub['url-match'])) {
-				$this->_match = $match;
+			$match = $this->_matchUrl($url, (array)$stub['url-match']);
+			if (!$match) {
+				continue;
+			}
 
-				if (!empty($stub['fetch-match'])) {
-					if (!$this->_parseLink($url, $stub['fetch-match'])) {
-						return null;
-					}
-				}
+			$this->_match = $match;
 
-				$stub['match'] = $this->_match;
-				$Object = $this->object($stub, $config + $this->config);
-				return $Object;
+			if (!empty($stub['fetch-match'])) {
+				if (!$this->_parseLink($url, $stub['fetch-match'])) {
+					return null;
+				}
 			}
+
+			$stub['match'] = $this->_match;
+			$Object = $this->object($stub, $config + $this->config);
+			return $Object;
 		}
 	}
 

src/MediaEmbed/Object/MediaObject.php

@@ -119,6 +119,8 @@ public function stub($property = null, $value = null) {
 
 	/**
 	 * {@inheritdoc}
+	 *
+	 * @return string
 	 */
 	public function id() {
 		$res = $this->_match;
@@ -140,13 +142,17 @@ public function id() {
 
 	/**
 	 * {@inheritdoc}
+	 *
+	 * @return string
 	 */
 	public function slug() {
 		return $this->_stub['slug'];
 	}
 
 	/**
 	 * {@inheritdoc}
+	 *
+	 * @return string
 	 */
 	public function name() {
 		$res = $this->_match;