New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wishlist: flip/mirror images #53

Closed
ecraven opened this Issue Aug 9, 2011 · 7 comments

Comments

Projects
None yet
3 participants
@ecraven

ecraven commented Aug 9, 2011

As feh can already rotate images, it would be great if vertical and horizontal flipping were also implemented.
Thanks!
Peter

@livibetter

This comment has been minimized.

Contributor

livibetter commented Aug 9, 2011

@derf, what do you think about @c78cee50a4c33e2286ad? (Doc hasn't added yet.)

I expanded the current in-place edit to include these two new actions.

(PS. There are 9 issues opened currently, but this one is #53. So embarrassing... and there is typo.)

@derf

This comment has been minimized.

Owner

derf commented Aug 9, 2011

@livibetter, yup, that one looks good. I don't know where to pull and merge your commit, though... github is confusing me.

@livibetter

This comment has been minimized.

Contributor

livibetter commented Aug 9, 2011

I will open a pull request later. I haven't added doc and do I need to assign default keys for them? If so, any suggestions?

@derf

This comment has been minimized.

Owner

derf commented Aug 9, 2011

Just found it. Assigning default keys probably won't hurt, yeah.

I could also merge now and add documentation & default keys myself, choice is all yours ;)

As keys, | for vertical flip and _ for horizontal flip ("mirror") should be okay.

@livibetter

This comment has been minimized.

Contributor

livibetter commented Aug 9, 2011

oh wait, about doc, maybe you will add later? (I have no idea how to edit man page)

@livibetter

This comment has been minimized.

Contributor

livibetter commented Aug 9, 2011

oops, we are comment-racing.

Okay merge now, and I will let you do the doc and default keys. (I am lazy) :D

@derf derf closed this in 5a280fd Aug 9, 2011

@ecraven

This comment has been minimized.

ecraven commented Aug 11, 2011

thank you very much, works perfectly!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment