Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pull out IP-picking magic, allow it to be passed in instead. #1

Merged
merged 1 commit into from Feb 22, 2014

Conversation

@EvanKrall
Copy link
Contributor

EvanKrall commented Feb 20, 2014

This is an API-breaking change - anybody who was depending on the ipaddress_public/public_ip lookup behavior before will need to pass that in instead, e.g.

class {'mesos::master':
  listen_addr => $::ipaddress_public,
}

The reason for this change is because the logic is choosing an unfortunate IP address on my test box: facter's $ipaddress takes the first IP that ifconfig gives, which on my box is the IP assigned to the docker0 interface. I'll be overriding this with listen_addr => $::ipaddress_eth0.

@deric

This comment has been minimized.

Copy link
Owner

deric commented Feb 21, 2014

Looks good, thanks for your contribution! It was an dirty fix to bypass the issue with docker, as you are mentioning. Facter shouldn't assign 172.17.42.1 as public address, I think it's a facter bug (or is it a feature?).

I would call the parameter listen_address instead of listen_addr, what do you think?

@EvanKrall

This comment has been minimized.

Copy link
Contributor Author

EvanKrall commented Feb 21, 2014

listen_address is fine, will update the change when I'm in front of a real keyboard.

Definitely agree that it's a facter bug (maybe it should be looking for the interface that carries the default route), but I also think it would be useful for this module to be configurable even if facter gave the right IP.

…sos::slave or mesos::master instead.
@EvanKrall

This comment has been minimized.

Copy link
Contributor Author

EvanKrall commented Feb 21, 2014

Patch is updated.

@deric

This comment has been minimized.

Copy link
Owner

deric commented Feb 22, 2014

Cool, thanks!

deric added a commit that referenced this pull request Feb 22, 2014
Pull out IP-picking magic, allow it to be passed in instead.
@deric deric merged commit 06a2a53 into deric:master Feb 22, 2014
1 check passed
1 check passed
default The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.