From 050fbb7ea8007a5c4c633909cda25847e73e8655 Mon Sep 17 00:00:00 2001 From: Sebastian J Date: Mon, 9 Jul 2018 14:31:26 -0400 Subject: [PATCH] More coverage --- src/site/resources/spring-dynamodb-1.0.xsd | 17 +++ ...amoDBAuditingBeanDefinitionParserTest.java | 132 ++++++++++++++++++ .../org.mockito.plugins.MockMaker | 1 + 3 files changed, 150 insertions(+) create mode 100644 src/test/java/org/socialsignin/spring/data/dynamodb/config/DynamoDBAuditingBeanDefinitionParserTest.java create mode 100644 src/test/resources/mockito-extensions/org.mockito.plugins.MockMaker diff --git a/src/site/resources/spring-dynamodb-1.0.xsd b/src/site/resources/spring-dynamodb-1.0.xsd index aab0d6db..12da36a9 120000 --- a/src/site/resources/spring-dynamodb-1.0.xsd +++ b/src/site/resources/spring-dynamodb-1.0.xsd @@ -1 +1,18 @@ + ../../main/resources/org/socialsignin/spring/data/dynamodb/repository/config/spring-dynamodb-1.0.xsd \ No newline at end of file diff --git a/src/test/java/org/socialsignin/spring/data/dynamodb/config/DynamoDBAuditingBeanDefinitionParserTest.java b/src/test/java/org/socialsignin/spring/data/dynamodb/config/DynamoDBAuditingBeanDefinitionParserTest.java new file mode 100644 index 00000000..370adbe3 --- /dev/null +++ b/src/test/java/org/socialsignin/spring/data/dynamodb/config/DynamoDBAuditingBeanDefinitionParserTest.java @@ -0,0 +1,132 @@ +/** + * Copyright © 2018 spring-data-dynamodb (https://github.com/derjust/spring-data-dynamodb) + * + * Licensed under the Apache License, Version 2.0 (the "License"); + * you may not use this file except in compliance with the License. + * You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.socialsignin.spring.data.dynamodb.config; + +import javax.xml.parsers.DocumentBuilder; +import javax.xml.parsers.DocumentBuilderFactory; + +import org.junit.Before; +import org.junit.Test; +import org.junit.runner.RunWith; +import org.mockito.Mock; +import org.mockito.junit.MockitoJUnitRunner; +import org.socialsignin.spring.data.dynamodb.mapping.DynamoDBMappingContext; +import org.socialsignin.spring.data.dynamodb.mapping.event.AuditingEventListener; +import org.springframework.beans.factory.support.BeanDefinitionBuilder; +import org.springframework.beans.factory.support.BeanDefinitionRegistry; +import org.springframework.beans.factory.support.GenericBeanDefinition; +import org.springframework.beans.factory.support.RootBeanDefinition; +import org.springframework.beans.factory.xml.ParserContext; +import org.springframework.beans.factory.xml.XmlReaderContext; +import org.w3c.dom.Document; +import org.w3c.dom.Element; + +import static org.junit.Assert.assertEquals; +import static org.junit.Assert.assertTrue; +import static org.mockito.ArgumentMatchers.isA; +import static org.mockito.Mockito.any; +import static org.mockito.Mockito.eq; +import static org.mockito.Mockito.when; +import static org.mockito.Mockito.verify; +import static org.socialsignin.spring.data.dynamodb.config.BeanNames.MAPPING_CONTEXT_BEAN_NAME; + +@RunWith(MockitoJUnitRunner.class) +public class DynamoDBAuditingBeanDefinitionParserTest { + + private DynamoDBAuditingBeanDefinitionParser underTest; + private Document configXmlDoc; + + @Mock + private ParserContext parserContext; + @Mock + private BeanDefinitionRegistry registry; + @Mock + private BeanDefinitionBuilder builder; + @Mock + private XmlReaderContext readerContext; + + @Before + public void setUp() throws Exception { + underTest = new DynamoDBAuditingBeanDefinitionParser(); + + DocumentBuilder documentBuilder = DocumentBuilderFactory.newInstance().newDocumentBuilder(); + configXmlDoc = documentBuilder.newDocument(); + + when(parserContext.getRegistry()).thenReturn(registry); + when(parserContext.getReaderContext()).thenReturn(readerContext); + when(readerContext.generateBeanName(any())).thenReturn("dynamoDBMappingContext"); + } + + @Test + public void testGetBeanClass() { + Element element = null; + Class actual = underTest.getBeanClass(element); + + assertEquals(AuditingEventListener.class, actual); + } + + @Test + public void testShouldGenerateId() { + + assertTrue(underTest.shouldGenerateId()); + } + + @Test + public void testDoParseWithMappingContext() { + + String mappingContextRef = MAPPING_CONTEXT_BEAN_NAME; + Element configElement = configXmlDoc.createElement("config"); + configElement.setAttribute("mapping-context-ref", mappingContextRef); + + underTest.doParse(configElement, parserContext, builder); + + verify(builder).addConstructorArgValue(any()); + } + + @Test + public void testDoParseWithoutMappingContextAutocreatingBean() { + // mappingContextRef not set + String mappingContextRef = null; + Element configElement = configXmlDoc.createElement("config"); + configElement.setAttribute("mapping-context-ref", mappingContextRef); + + // Default bean not yet registered + when(registry.containsBeanDefinition(MAPPING_CONTEXT_BEAN_NAME)).thenReturn(false); + + underTest.doParse(configElement, parserContext, builder); + + verify(registry).registerBeanDefinition(MAPPING_CONTEXT_BEAN_NAME, + new RootBeanDefinition(DynamoDBMappingContext.class)); + + verify(builder).addConstructorArgValue(any()); + } + + @Test + public void testDoParseWithoutMappingContextReusingBean() { + // mappingContextRef not set + String mappingContextRef = null; + Element configElement = configXmlDoc.createElement("config"); + configElement.setAttribute("mapping-context-ref", mappingContextRef); + + // Default bean not yet registered + when(registry.containsBeanDefinition(MAPPING_CONTEXT_BEAN_NAME)).thenReturn(true); + + underTest.doParse(configElement, parserContext, builder); + + verify(registry).registerBeanDefinition(eq(MAPPING_CONTEXT_BEAN_NAME), isA(GenericBeanDefinition.class)); + verify(builder).addConstructorArgValue(any()); + } +} diff --git a/src/test/resources/mockito-extensions/org.mockito.plugins.MockMaker b/src/test/resources/mockito-extensions/org.mockito.plugins.MockMaker new file mode 100644 index 00000000..1f0955d4 --- /dev/null +++ b/src/test/resources/mockito-extensions/org.mockito.plugins.MockMaker @@ -0,0 +1 @@ +mock-maker-inline