Removes checks for system(), which is C89/90 (HDFGroup#782)

derobins · Jun 30, 2021 · b1be540 · b1be540
1 parent 35682a3
commit b1be540
Show file tree

Hide file tree

Showing 4 changed files with 4 additions and 10 deletions.
diff --git a/config/cmake/H5pubconf.h.in b/config/cmake/H5pubconf.h.in
@@ -355,9 +355,6 @@
 /* Define to 1 if you have the `symlink' function. */
 #cmakedefine H5_HAVE_SYMLINK @H5_HAVE_SYMLINK@
 
-/* Define to 1 if you have the `system' function. */
-#cmakedefine H5_HAVE_SYSTEM @H5_HAVE_SYSTEM@
-
 /* Define to 1 if you have the <sys/file.h> header file. */
 #cmakedefine H5_HAVE_SYS_FILE_H @H5_HAVE_SYS_FILE_H@
 

diff --git a/config/cmake_ext_mod/ConfigureChecks.cmake b/config/cmake_ext_mod/ConfigureChecks.cmake
@@ -72,7 +72,6 @@ if (WINDOWS)
   set (${HDF_PREFIX}_HAVE_WIN32_API 1)
   set (${HDF_PREFIX}_HAVE_LIBM 1)
   set (${HDF_PREFIX}_HAVE_STRDUP 1)
-  set (${HDF_PREFIX}_HAVE_SYSTEM 1)
   set (${HDF_PREFIX}_HAVE_LONGJMP 1)
   if (NOT MINGW)
     set (${HDF_PREFIX}_HAVE_GETHOSTNAME 1)
@@ -495,7 +494,6 @@ CHECK_FUNCTION_EXISTS (sigtimedwait      ${HDF_PREFIX}_HAVE_SIGTIMEDWAIT)
 CHECK_FUNCTION_EXISTS (srandom           ${HDF_PREFIX}_HAVE_SRANDOM)
 CHECK_FUNCTION_EXISTS (strdup            ${HDF_PREFIX}_HAVE_STRDUP)
 CHECK_FUNCTION_EXISTS (symlink           ${HDF_PREFIX}_HAVE_SYMLINK)
-CHECK_FUNCTION_EXISTS (system            ${HDF_PREFIX}_HAVE_SYSTEM)
 
 CHECK_FUNCTION_EXISTS (tmpfile           ${HDF_PREFIX}_HAVE_TMPFILE)
 CHECK_FUNCTION_EXISTS (timespeccmp       ${HDF_PREFIX}_HAVE_TIMESPECCMP)

diff --git a/configure.ac b/configure.ac
@@ -2023,11 +2023,12 @@ AC_CHECK_FUNCS([alarm clock_gettime difftime fcntl flock fork frexpf])
 AC_CHECK_FUNCS([frexpl gethostname getrusage gettimeofday])
 AC_CHECK_FUNCS([lstat rand_r random setsysinfo])
 AC_CHECK_FUNCS([signal longjmp setjmp siglongjmp sigsetjmp sigprocmask])
-AC_CHECK_FUNCS([sigtimedwait])
-AC_CHECK_FUNCS([srandom strdup symlink system])
-AC_CHECK_FUNCS([timespeccmp])
+AC_CHECK_FUNCS([srandom strdup symlink])
 AC_CHECK_FUNCS([tmpfile asprintf vasprintf waitpid])
 
+## VFD SWMR (move to main CHECK_FUNCS section at merge time)
+AC_CHECK_FUNCS([sigtimedwait timespeccmp])
+
 ## ----------------------------------------------------------------------
 ## Check compiler characteristics
 ##

diff --git a/tools/test/perform/iopipe.c b/tools/test/perform/iopipe.c
@@ -95,7 +95,6 @@ print_stats(const char *prefix,
 static void
 synchronize(void)
 {
-#ifdef H5_HAVE_SYSTEM
 #if defined(H5_HAVE_WIN32_API) && !defined(__CYGWIN__)
     _flushall();
 #else
@@ -107,7 +106,6 @@ synchronize(void)
     status = HDsystem("df >/dev/null");
     HDassert(status >= 0);
 #endif
-#endif
 }
 
 /*-------------------------------------------------------------------------