Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Some suggestions #1

Closed
MartijnKaijser opened this Issue Nov 9, 2011 · 4 comments

Comments

Projects
None yet
2 participants

It's better to try one time to set a folder and than fail. Now you can get out of the 'while' loop.
Add this [ option="writeable" ] to the settings.xml This will enable the 'new folder' in the select folder dialog.

Owner

dersphere commented Nov 9, 2011

Hi,

thanks for your comments.

regarding the while loop: I will think about that - at least changing the ok-dialog to yesno-dialog with "no folder set. Do you want to set now?" and if no is chosen it will exit.

regarding the writable: Thanks for that hint! :)

I will commit your suggestions in the next hour...

regards,
sphere

dersphere added a commit that referenced this issue Nov 9, 2011

dersphere added a commit that referenced this issue Nov 9, 2011

rewrote "no output folder set"-behavior
thx to Machine-Sanctum in #1

Great :)
Your goal was to potentially add this to the xbmc repo?
If so than for Eden you need to python import to version 2.0
For Dharma it can stay at 1.0
No difference what so ever only that the xbmc dev's want it that way.

Owner

dersphere commented Nov 9, 2011

Thanks for your hints, but no need to tell me that - have a look at my other repositories :D
And fyi, there are indeed differences in xbmc's python api 1 vs. 2 (for example xbmcvfs does not exist in dharma) ;)

will close that issue - feel free to open new ones :)

@dersphere dersphere closed this Nov 9, 2011

lol
Didn't look further than this one. Well thanks for this script. I definitely needed the docs for our own add-on. Only done python coding for a month.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment