Added the ability to pass an element as the handle

[beauwest]

Added the ability to pass an element as the handle. This enables Polymer ShadowDom elements to be used as the handle as well. Or just passing an element directly if you don't want it to use querySelectorAll();

[desandro]

Thank you for this contribution! This could be a useful feature. But I'd prefer to hear other's input before it gets merged.

If you would like to see this feature please +1

[beauwest]

Do I get to 👍 my own? Haha!

Just to clarify, this will not break any existing selectors. All it does is extend the handle: configuration to allow passing a reference to a DOM element that you already have access to. Theoretically it could make getting the handler a tiny bit more efficient if you already have the DOM Element reference defined.

[beauwest]

One thing to note, Draggabilly already does this on the element that's being passed in:

this.element = typeof element === 'string' ? document.querySelector( element ) : element;

[beauwest]

Is there any update on this? Thanks @desandro.

[davitv]

+1
Same code for handle i have added for my own project when was implementing tree with drag'n'drop functions. The problem was that the handle class for a particular draggable tree element existed also in it's child elements and i needed way to define already selected element as a handler. Would be nice to see it in master branch

[desandro]

@davitv I recommend using a unique handle class if that's the case.

I'm closing this PR as this feature didn't get enough support.

[beauwest]

It's your project, I'm just very confused why a simple, non-conflicting code change, that in some cases prevents double querySelector/elementByID lookups, would be rejected.

[ahenager]

I'd also like this change, and it wouldn't hurt anything else, would it? I always try to avoid having to run my own fork when I can, and this change is much preferable to having extra code in my project to deal with this.

[nomadme]

+1

[shepherdsam]

+1

[navanjr]

+1

[gillsonkell]

+1

[davitv]

No @desandro, i don't want to create an unique class for every tree node, and why should i, if it is better to pass a handle as a dom element, which is already selected before for other purposes.

[ferllings]

Any news on this?
I have an Polymer element where the handle is inside the ShadowDOM.
So this would be very useful.

[beauwest]

In the latest version, since my pull request was rejected, I've had to overwrite the setHandles method.

var handleElement = this.$.handle;
Draggabilly.prototype.setHandles = function () {
    this.handles = [handleElement];
    this.bindHandles();
};

Not ideal at all, but it's the simplest way to fix the issue that prevents Draggabilly from supporting native ShadowDOM.