checkbox, click event doesn't stop propagation #374

clarkorz opened this Issue Feb 19, 2014 · 1 comment

2 participants


flatui-checkbox.js, line 99

e && e.preventDefault() && e.stopPropagation();

e.stopPropagation() will never execute, because e.preventDefault() has no return value (always undefined).

change to this will work:

e && (e.preventDefault() || e.stopPropagation());

Hi, clarkorz,
thanks for help, now checkbox component is completely rewritten, we don't use this code anymore.

@andrew-ml andrew-ml closed this Oct 3, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment