New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Baseline Styleguide #86

Closed
Moodycomputer opened this Issue Feb 4, 2014 · 9 comments

Comments

Projects
None yet
2 participants
@Moodycomputer
Contributor

Moodycomputer commented Feb 4, 2014

At the Designathon @GarthDB and I attended this last weekend, I worked on a baseline but open styleguide for the general site.

As is, it's bare-bones, basic and simple. Perfect for enhancements from all over the joint.

As a nice-to-have, I installed a jekyll-sass plugin, so our main stylesheet is now in scss.

This whole shebang lives on the styleguide branch. If you'd like, pull down, check it out and make sure it's not breaking anything major. I plan on merging it into master as soon as I get an article written about the process and how to contribute to it.

@GarthDB

This comment has been minimized.

Show comment
Hide comment
@GarthDB

GarthDB Feb 4, 2014

Member

Some screenshots
screenshot 2014-02-04 13 20 37
screenshot 2014-02-04 13 24 19

Member

GarthDB commented Feb 4, 2014

Some screenshots
screenshot 2014-02-04 13 20 37
screenshot 2014-02-04 13 24 19

@Moodycomputer

This comment has been minimized.

Show comment
Hide comment
@Moodycomputer

Moodycomputer Feb 4, 2014

Contributor

Thanks for the screenshots @GarthDB.

I had a thought about how the site and layouts are structured while fleshing this out. We've got 3 basic divisions of the site: Home, Blog and Resources. They all share the same base layout (default). Does it make sense to break those layouts out entirely, so that the three units can be edited and worked on in more divided chunks?

I'm not sure this would make sense if the project were tighter or had a defined team, but since we're setting this up to make it as easy as possible for someone to come in a make changes that they are comfortable pushing back to the repo, is it going to be better to divide these more aggressively?

Contributor

Moodycomputer commented Feb 4, 2014

Thanks for the screenshots @GarthDB.

I had a thought about how the site and layouts are structured while fleshing this out. We've got 3 basic divisions of the site: Home, Blog and Resources. They all share the same base layout (default). Does it make sense to break those layouts out entirely, so that the three units can be edited and worked on in more divided chunks?

I'm not sure this would make sense if the project were tighter or had a defined team, but since we're setting this up to make it as easy as possible for someone to come in a make changes that they are comfortable pushing back to the repo, is it going to be better to divide these more aggressively?

@GarthDB GarthDB closed this Feb 4, 2014

@GarthDB GarthDB reopened this Feb 4, 2014

@GarthDB

This comment has been minimized.

Show comment
Hide comment
@GarthDB

GarthDB Feb 4, 2014

Member

I think the blog and resources should be use the same styling

Member

GarthDB commented Feb 4, 2014

I think the blog and resources should be use the same styling

@Moodycomputer

This comment has been minimized.

Show comment
Hide comment
@Moodycomputer

Moodycomputer Feb 4, 2014

Contributor

I'm cool with that, they follow the same basic layouts.

Contributor

Moodycomputer commented Feb 4, 2014

I'm cool with that, they follow the same basic layouts.

@GarthDB

This comment has been minimized.

Show comment
Hide comment
@GarthDB

GarthDB Feb 4, 2014

Member

@terracomma Now that the css is getting a little bit more complex I think we should look at BEM

Member

GarthDB commented Feb 4, 2014

@terracomma Now that the css is getting a little bit more complex I think we should look at BEM

@GarthDB

This comment has been minimized.

Show comment
Hide comment
@GarthDB

GarthDB Feb 4, 2014

Member

Or something like it. The custom sites don't have to get too crazy with the coding guidelines, but the default stuff should be exemplary.

Member

GarthDB commented Feb 4, 2014

Or something like it. The custom sites don't have to get too crazy with the coding guidelines, but the default stuff should be exemplary.

@Moodycomputer

This comment has been minimized.

Show comment
Hide comment
@Moodycomputer

Moodycomputer Feb 4, 2014

Contributor

I'm cool with calling for a methodology like BEM, but I'd rather re-hash the more important bits and maybe write out our own version of those guidelines.

I don't want to hit a point where we tell someone "Yeah! We'd love your input! Just go read these 7 different websites first"

Contributor

Moodycomputer commented Feb 4, 2014

I'm cool with calling for a methodology like BEM, but I'd rather re-hash the more important bits and maybe write out our own version of those guidelines.

I don't want to hit a point where we tell someone "Yeah! We'd love your input! Just go read these 7 different websites first"

@GarthDB

This comment has been minimized.

Show comment
Hide comment
@GarthDB

GarthDB Feb 4, 2014

Member

True, but if our stuff gets halfway complex we might end up writing our own seven different websites. OOCSS, SMACSS, and BEM are good at eliminating the need for 90% or organization discussions.

We don't have to be crazy, it's just up to us making the default stuff.

Member

GarthDB commented Feb 4, 2014

True, but if our stuff gets halfway complex we might end up writing our own seven different websites. OOCSS, SMACSS, and BEM are good at eliminating the need for 90% or organization discussions.

We don't have to be crazy, it's just up to us making the default stuff.

@Moodycomputer

This comment has been minimized.

Show comment
Hide comment
@Moodycomputer

Moodycomputer Feb 4, 2014

Contributor

I'm on board.

Contributor

Moodycomputer commented Feb 4, 2014

I'm on board.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment