-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Finding of fibers + angles #102
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On Fri, 2020-06-26 at 11:12 -0700, julienguy wrote:
Thank you Sergey!
If you don't mind we will rework the script, because we already have a full infrastructure to analysis the back illuminated fibers. I'll keep you in the loop.
sure
A future improvement would be to detect the phi arms of positioners with broken fibers.
I think it should not be too difficult if we focus only on the region where we know a detection is missing.
Yes, I think given that I have the outline of the fiber now I think it is possible
(and I was planning to do it originally) to
just
1) apply the canny filter to the whole image (in blocks to avoid issues due to brightness gradients)
2) then apply matched filters of rotated fiber outlines to identify fibers including broken ones .
That removes the need to rely on the back illuminated image.
|
Merged
I have reorganize this code into routines, added multiprocessing, and included it in a script that also does the match to the metrology. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is my script to find fibers + angles.
The script depends on sep package + scikit-image. (I didn't add them to requirements.txt yet)