Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Finding of fibers + angles #102

Closed
wants to merge 7 commits into from
Closed

Conversation

segasai
Copy link

@segasai segasai commented Jun 26, 2020

This is my script to find fibers + angles.
The script depends on sep package + scikit-image. (I didn't add them to requirements.txt yet)

@julienguy
Copy link
Collaborator

Thank you Sergey!

If you don't mind we will rework the script, because we already have a full infrastructure to analysis the back illuminated fibers. I'll keep you in the loop.

A future improvement would be to detect the phi arms of positioners with broken fibers.
I think it should not be too difficult if we focus only on the region where we know a detection is missing.
Screenshot from 2020-06-26 11-10-35

@segasai
Copy link
Author

segasai commented Jun 26, 2020 via email

@segasai
Copy link
Author

segasai commented Jun 28, 2020

Just one more comment. I've played a bit with the code trying to see if it is possible to detect the fibers without the back illuminated image (i.e. to detect the broken fibers). here is the result applying matched filter technique (on the left is the filtered image with peaks corresponding to the location of fibers and the actual image on the right.
experiment
I don't think in the current form it can work reliably enough (unless we have a good idea of a small area where the broken fiber should be in the plane)
(the code performing that search is in the last experimental commit)

@sbailey sbailey mentioned this pull request Jun 29, 2020
@julienguy
Copy link
Collaborator

I have reorganize this code into routines, added multiprocessing, and included it in a script that also does the match to the metrology.
This is in another branch bright-image-analysis, so I am closing this PR.

@julienguy julienguy closed this Jun 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants