Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug when reading transmision files with hdu named F_METALS. #497

Merged
merged 1 commit into from Jun 24, 2019

Conversation

alxogm
Copy link
Contributor

@alxogm alxogm commented Jun 24, 2019

This PR fixes a bug found when trying to run quickquasar on the London mocks v8.0, and we are also using it to save global seed and pixel seed in the truth files. Output is as indicated below...

test=fits.open("/project/projectdirs/desi/users/alxogm/desi/mocks/london/metals/v8.0.0/truth-16-0.fits")
test.info()
Filename: /project/projectdirs/desi/users/alxogm/desi/mocks/london/metals/v8.0.0/truth-16-0.fits
No.    Name      Ver    Type      Cards   Dimensions   Format
  0  PRIMARY       1 PrimaryHDU       6   ()      
  1  TRUTH         1 BinTableHDU     51   5R x 18C   [K, 10A, 10A, I, K, E, E, 15A, E, E, E, E, E, E, D, D, D, E]   
  2  QSO_META      1 BinTableHDU     21   5R x 5C   [K, E, 5E, 186E, I]   

test[0].header
[32]:
SIMPLE  =                    T / conforms to FITS standard                      
BITPIX  =                    8 / array data type                                
NAXIS   =                    0 / number of array dimensions                     
EXTEND  =                    T                                                  
GSEED   =                  123                                                  
PIXSEED =                 2866   

Save global seed and pixel seed in the truth files
@alxogm alxogm requested a review from londumas June 24, 2019 19:56
py/desisim/lya_spectra.py Show resolved Hide resolved
@londumas
Copy link
Contributor

Thanks @alxogm, I have a small request for the error message.

@alxogm
Copy link
Contributor Author

alxogm commented Jun 24, 2019

OK. I'll merge now.

@alxogm alxogm merged commit 4fc8f98 into master Jun 24, 2019
@alxogm alxogm deleted the qquasar_saveseed branch June 24, 2019 21:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants