Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix isLRG vs. isLRG_colors #200

Merged
merged 5 commits into from Jul 16, 2017
Merged

fix isLRG vs. isLRG_colors #200

merged 5 commits into from Jul 16, 2017

Conversation

sbailey
Copy link
Contributor

@sbailey sbailey commented Jul 14, 2017

This PR

  • switches to using isLRG_colorcuts instead of isLRG when applying cuts to mock spectra (Similar to use isLRG_colors for color-cuts desisim#246)
  • fixes random seed propagation when processing pixels in parallel (it was fixed for 2% sprint but I accidentally deleted my git repo before committing, so refixing now...)

Smaller but important changes to get things back into a working state:

  • fix a vestigial (and crash inducing) clobber=True in mpi_select_mock_targets
  • drop back to processing a single healpixel at a time per rank instead of groups of healpixels to avoid blowing out memory.
  • don't impose DEBUG-level logging on everyone that imports desitarget.mock.io
    (see Questions/suggestions for logging module desiutil#66 for a longer-term cleanup of this type of problem)
  • use x[col][:] = values instead of x[col] = values which changes the dtype starting with astropy 1.3, resulting in output files having different formats (e.g. S10 vs. S13) for different pixels.

@sbailey sbailey requested a review from moustakas July 14, 2017 18:20
@moustakas moustakas merged commit b26924f into master Jul 16, 2017
@moustakas moustakas deleted the mock-scaling branch July 16, 2017 10:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants