Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mock targets QA and scaling improvements #235

Merged
merged 3 commits into from Nov 8, 2017
Merged

Mock targets QA and scaling improvements #235

merged 3 commits into from Nov 8, 2017

Conversation

sbailey
Copy link
Contributor

@sbailey sbailey commented Nov 7, 2017

This PR has some improvements for working with mock targets:

  • updates QA code so that it works on both real data and mock data. The latter is currently missing RELEASE and W1 fluxes which was crashing the QA code. This current fix is to let the QA code go on with blank plots, rather than the harder fix of getting those into mock data.
  • updates mpi_select_mock_targets for scaling robustness, e.g. logging each rank to a different file instead of N>>1 ranks all blasting the same stderr/stdout.

Copy link
Contributor

@geordie666 geordie666 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

QA still works for me on this branch. I'll go ahead and merge this.

@geordie666 geordie666 merged commit db92a21 into master Nov 8, 2017
@geordie666 geordie666 deleted the mock_targets branch November 8, 2017 17:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants