New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add URAT catalog information #526
Conversation
…nsities, to limit I/O
…=4 where appropriate
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Structural quibbling: It seems odd to have a py/desitarget/fortran/ directory (i.e. fortran under python).
I certainly hope we aren't planning on adding more fortran. I would like this better
if everything URAT related was in a py/desitarget/urat directory, or if the fortran code
was moved out of py/desitarget and into a top level fortran/ or urat/ or
etc/urat/ directory.
Is having a copy of the URAT catalog processed by v1dump now required to be able to run gfa_targets? Is that what we want? For production yes; might be a hassle for development, though I'm not aware of anyone running this part of desitarget away from NERSC anyway. Just raising it for consideration.
A few other small comments inline.
Note that it will now be required to have the URAT catalog to run GFAs. But, it was already required to have the suitably-formatted Gaia catalog to run GFAs. The second (Gaia) is a far greater burden that the first (URAT), so I'm comfortable with it being a requirement. |
I'd be 100% against moving the Fortran directory to the top level. I don't want to give the impression that we're expecting to add more Fortran code. In other words, Fortran is a "special case" under Python, here. The Python is a wrapper on it. Moving the Fortran to a top-level directory would imply that it has equal and substantial weight. I also don't want to move everything into a urat directory, which would beg the question of why the |
@sbailey: I believe I addressed all of your requests. I also:
I'm running a few tests of these changes. I'll let you know when I'm done. |
@sbailey: OK, I'm done with internal tests. Let me know if you want more changes. |
Looks good; thanks. Merging now. |
Add URAT catalog information
This PR adds the URAT catalog to desitarget. It includes:
uratmatch.py
to retrieve URAT data from Vizier/FTP and reformat it.uratmatch.py
module.This addresses #520. Here's an example of a general region we uncovered that had zero objects in a guide camera, which now has multiple objects from URAT: